linux: set LC_NUMERIC to C for all non-browser processes

linux: set LC_NUMERIC to C for all non-browser processes

In languages where comma is a decimal separator, printf() will obey the
locale.  This makes all sorts of things break (see bugs).  We can
sidestep these bugs by adjusting the locale early on.

BUG=22782, 39964
TEST=tried the test steps in r21586 (verifying a Japanese filename
uploaded), as well as tested a webm video in a German locale

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73225

[Evan Martin, 2011-01-31 22:51:37]

http://codereview.chromium.org/6347045/diff/1/chrome/browser/zygote_main_linu...
File chrome/browser/zygote_main_linux.cc (left):

http://codereview.chromium.org/6347045/diff/1/chrome/browser/zygote_main_linu...
chrome/browser/zygote_main_linux.cc:593: // called before the sandbox is
triggered. It's possible to avoid calling
I repeated this test that prompted this extra code with this code removed and it
still worked.  We call setlocale() early on in startup.

[piman, 2011-01-31 23:11:01]

http://codereview.chromium.org/6347045/diff/1/chrome/app/chrome_main.cc
File chrome/app/chrome_main.cc (right):

http://codereview.chromium.org/6347045/diff/1/chrome/app/chrome_main.cc#newco...
chrome/app/chrome_main.cc:384: setlocale(LC_NUMERIC, "C");
I'm not sure setting it for plugins is a good idea though... I know Flash at
least looks at LC_NUMERIC.

[Evan Martin, 2011-01-31 23:12:18]

On 2011/01/31 23:11:01, piman wrote:
>
http://codereview.chromium.org/6347045/diff/1/chrome/app/chrome_main.cc#newco...
> chrome/app/chrome_main.cc:384: setlocale(LC_NUMERIC, "C");
> I'm not sure setting it for plugins is a good idea though... I know Flash at
> least looks at LC_NUMERIC.

I was hoping for your advice on this.  My general attitude is that if there is a
way to get something wrong, Flash will find it and do it wrong, so we're
probably better off this way.  But I can be convinced either way.

[piman, 2011-01-31 23:24:34]

On Mon, Jan 31, 2011 at 3:12 PM, <evan@chromium.org> wrote:

> On 2011/01/31 23:11:01, piman wrote:
>
>
>
http://codereview.chromium.org/6347045/diff/1/chrome/app/chrome_main.cc#newco...
>
>> chrome/app/chrome_main.cc:384: setlocale(LC_NUMERIC, "C");
>> I'm not sure setting it for plugins is a good idea though... I know Flash
>> at
>> least looks at LC_NUMERIC.
>>
>
> I was hoping for your advice on this.  My general attitude is that if there
> is a
> way to get something wrong, Flash will find it and do it wrong, so we're
> probably better off this way.  But I can be convinced either way.


Ok, maybe we can try it this way first and see what breaks...

LGTM

>
>
> http://codereview.chromium.org/6347045/
>

[awong, 2011-01-31 23:38:33]

LGTM

(this still feels scary, but not sure if there's a better solution)