Issue 6347015: This fixes a problem with the aw snap page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6347015: This fixes a problem with the aw snap page (Closed)

Created:
9 years, 11 months ago by Greg Spencer (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

This fixes a problem with the aw snap page that I introduced where if you run "about:kill" or kill a page first, and then run "about:crash" in the same window, then it shows the killed page instead of the crashed page, and vice-versa. BUG=none TEST=tried "about:kill", then "about:crash", and then "about:kill" again in the same session, and vice versa. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72842

Patch Set 1 #

Patch Set 2 : Adding windows fix #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -18 lines)			Patch
	M	chrome/browser/ui/views/tab_contents/tab_contents_view_gtk.cc	View		1 chunk	+7 lines, -9 lines	0 comments	Download
	M	chrome/browser/ui/views/tab_contents/tab_contents_view_win.cc	View	1	1 chunk	+7 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages