Issue 6346008: Attempt at fixing crash in tab code. It appears that we end up in a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6346008: Attempt at fixing crash in tab code. It appears that we end up in a (Closed)

Created:
9 years, 11 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Attempt at fixing crash in tab code. It appears that we end up in a situation where the opener ends up the same as the tab being closed. The only way I could see this happening is a new tab getting the same address as a tab that was deleted. This seems unlikely, but I've added the code to make sure we clean up properly when a tab is deleted. I'm also adding a couple more checks. BUG=34135 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71800

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -2 lines)			Patch
	M	chrome/browser/tabs/tab_strip_model.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/tabs/tab_strip_model.cc	View		5 chunks	+18 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

OK

Expand Messages | Collapse Messages