Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 6345001: Work around App Engine flakiness by retrying upon URLError... (Closed)

Created:
9 years, 11 months ago by Ken Russell (switch to Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
jam, M-A Ruel
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Work around App Engine flakiness by retrying upon URLError ("Connection timed out"). This allowed me to successfully upload a CL I have been stuck on for a couple of hours. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71513

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/upload.py View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ken Russell (switch to Gerrit)
Please review. Thanks. Please note that I'm seeing some presubmit test failures (testUpdateUnstagedConflict (__main__.GitWrapperTestCase), testUpdateCheckout ...
9 years, 11 months ago (2011-01-14 00:59:25 UTC) #1
M-A Ruel
You need to filter the error code since it could be a genuine invalid url ...
9 years, 11 months ago (2011-01-14 13:56:55 UTC) #2
Ken Russell (switch to Gerrit)
On 2011/01/14 13:56:55, Marc-Antoine Ruel wrote: > You need to filter the error code since ...
9 years, 11 months ago (2011-01-14 23:13:31 UTC) #3
M-A Ruel
lgtm I'll need to upstream it to rietveld though.
9 years, 11 months ago (2011-01-14 23:31:15 UTC) #4
jam
9 years, 11 months ago (2011-01-15 00:13:32 UTC) #5
I get a crash with this to the internal server, and I can only upload without
it:

Traceback (most recent call last):
 File "A:\depot_tools\gcl.py", line 1402, in <module>
   sys.exit(main(sys.argv[1:]))
 File "A:\depot_tools\gcl.py", line 1382, in main
   return command(argv[1:])
 File "A:\depot_tools\gcl.py", line 749, in hook
   return function(change_info, args)
 File "A:\depot_tools\gcl.py", line 866, in CMDupload
   issue, patchset = upload.RealMain(upload_arg, change_info.patch)
 File "A:\depot_tools\third_party\upload.py", line 1754, in RealMain
   response_body = rpc_server.Send("/upload", body, content_type=ctype)
 File "A:\depot_tools\third_party\upload.py", line 406, in Send
   reason = e.reason
AttributeError: 'HTTPError' object has no attribute 'reason'

Powered by Google App Engine
This is Rietveld 408576698