Fix common.sh to work in it's new location at /usr/lib/crosutils.

common.sh

Index: common.sh
diff --git a/common.sh b/common.sh
index a4d91384339d8fc61b450229f2149111eea1c3e1..4dfa86fe391f629eeb6c580f1170a5f6e878ddbf 100644
--- a/common.sh
+++ b/common.sh
@@ -17,32 +17,58 @@ NUM_JOBS=`grep -c "^processor" /proc/cpuinfo`
 # Store location of the calling script.
 TOP_SCRIPT_DIR="${TOP_SCRIPT_DIR:-$(dirname $0)}"
 
-# Find root of source tree
-if [ "x$GCLIENT_ROOT" != "x" ]
-then
-  # GCLIENT_ROOT already set, so we're done
-  true
-elif [ "x$COMMON_SH" != "x" ]
-then
-  # COMMON_SH set, so assume that's us
-  GCLIENT_ROOT="$(dirname "$COMMON_SH")/../.."
-elif [ "x$BASH_SOURCE" != "x" ]
+# Detect whether we're inside a chroot or not
+if [ -e /etc/debian_chroot ]
 then
-  # Using bash, so we can find ourselves
-  GCLIENT_ROOT="$(dirname "$BASH_SOURCE")/../.."
+  INSIDE_CHROOT=1
 else
-  # Using dash or sh, we don't know where we are.  $0 refers to the calling
-  # script, not ourselves, so that doesn't help us.
-  echo "Unable to determine location for common.sh.  If you are sourcing"
-  echo "common.sh from a script run via dash or sh, you must do it in the"
-  echo "following way:"
-  echo '  COMMON_SH="$(dirname "$0")/../../scripts/common.sh"'
-  echo '  . "$COMMON_SH"'
-  echo "where the first line is the relative path from your script to"
-  echo "common.sh."
-  exit 1
+  INSIDE_CHROOT=0
 fi
 
+# Construct a list of possible locations for the source tree.  This list is
+# based on various environment variables and globals that may have been set
+# by the calling script.
+function get_gclient_root_list() {
+  if [ $INSIDE_CHROOT -eq 1 ]; then echo "/home/${USER}/trunk"

[davidjames, 2011/01/26 23:41:33]

Since this isn't a one-line if statement, better to put a newline between 'then'
and 'echo'.

[robotboy, 2011/01/26 23:59:34]

Done.

+    if [ ! -z "${SUDO_USER}" ]; then echo "/home/${SUDO_USER}/trunk"; fi

[davidjames, 2011/01/26 23:41:33]

Any reason why you didn't use -n here (and elsewhere) instead of -z?

[robotboy, 2011/01/26 23:59:34]

Done.

+  fi
+
+  if [ ! -z "${COMMON_SH}" ]; then echo "$(dirname "$COMMON_SH")/../.."; fi
+  if [ ! -z "${BASH_SOURCE}" ]; then echo "$(dirname "$BASH_SOURCE")/../.."; fi
+}
+
+# Based on the list of possible source locations we set GCLIENT_ROOT if it is
+# not already defined by looking for a src directory in each seach path
+# location.  If we do not find a valid looking root we error out.
+function get_gclient_root() {
+  if [ ! -z "${GCLIENT_ROOT}" ]; then
+    return
+  fi
+
+  for path in $(get_gclient_root_list); do
+    if [ -d "${path}/src" ]; then
+      GCLIENT_ROOT=${path}
+      break
+    fi
+  done
+
+  if [ -z "${GCLIENT_ROOT}" ]; then
+    # Using dash or sh, we don't know where we are.  $0 refers to the calling
+    # script, not ourselves, so that doesn't help us.
+    echo "Unable to determine location for common.sh.  If you are sourcing"
+    echo "common.sh from a script run via dash or sh, you must do it in the"
+    echo "following way:"
+    echo '  COMMON_SH="$(dirname "$0")/../../scripts/common.sh"'
+    echo '  . "$COMMON_SH"'
+    echo "where the first line is the relative path from your script to"
+    echo "common.sh."
+    exit 1
+  fi
+}
+
+# Find root of source tree
+get_gclient_root
+
 # Canonicalize the directories for the root dir and the calling script.
 # readlink is part of coreutils and should be present even in a bare chroot.
 # This is better than just using
@@ -116,14 +142,6 @@ DEFAULT_BOARD=$(echo $ALL_BOARDS | awk '{print $NF}')
 # Enable --fast by default.
 DEFAULT_FAST="${FLAGS_TRUE}"
 
-# Detect whether we're inside a chroot or not
-if [ -e /etc/debian_chroot ]
-then
-  INSIDE_CHROOT=1
-else
-  INSIDE_CHROOT=0
-fi
-
 # Directory locations inside the dev chroot
 CHROOT_TRUNK_DIR="/home/$USER/trunk"