DOMUI: Alter the focus and selected list item background colors.

DOMUI: Alter the focus and selected list item background colors.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71829

[James Hawkins, 2011-01-19 03:33:24]

I'm seeing the 1px gap above the first item in a list, selected. Is this what
you were referring to in our earlier discussion?

[stuartmorgan, 2011-01-19 16:43:22]

http://codereview.chromium.org/6344008/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/options_page.css (right):

http://codereview.chromium.org/6344008/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/options_page.css:369: }
This rule needs to be split apart into the :focus rules (blue) and the others
(grey)

http://codereview.chromium.org/6344008/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/options_page.css:375: border-bottom: 1px solid
#b2b2b2;
These should change to some kind of blue.

[James Hawkins, 2011-01-19 19:06:18]

http://codereview.chromium.org/6344008/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/options_page.css (right):

http://codereview.chromium.org/6344008/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/options_page.css:369: }
On 2011/01/19 16:43:22, stuartmorgan wrote:
> This rule needs to be split apart into the :focus rules (blue) and the others
> (grey)

The list loses selection on blur, so I'm not sure why we need the rules at all.

http://codereview.chromium.org/6344008/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/options_page.css:375: border-bottom: 1px solid
#b2b2b2;
On 2011/01/19 16:43:22, stuartmorgan wrote:
> These should change to some kind of blue.

Done.

[stuartmorgan, 2011-01-19 19:48:51]

LGTM

http://codereview.chromium.org/6344008/diff/1/chrome/browser/resources/option...
File chrome/browser/resources/options/options_page.css (right):

http://codereview.chromium.org/6344008/diff/1/chrome/browser/resources/option...
chrome/browser/resources/options/options_page.css:369: }
On 2011/01/19 19:06:18, James Hawkins wrote:
> The list loses selection on blur, so I'm not sure why we need the rules at
all.

As discussed yesterday I want to do away with that, but I can just add the grey
at that point, so this is fine.

http://codereview.chromium.org/6344008/diff/5001/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.css:375: border-bottom: 1px solid
#b2b2b2;
Why rgb() for the backgrounds and hex for the border? It makes it hard to see
how the colors relate, which is weird for colors that need to go together, so it
would be cleaner to change one or the other so they all match.

[James Hawkins, 2011-01-19 20:00:24]

http://codereview.chromium.org/6344008/diff/5001/chrome/browser/resources/opt...
File chrome/browser/resources/options/options_page.css (right):

http://codereview.chromium.org/6344008/diff/5001/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.css:375: border-bottom: 1px solid
#7892b4;
On 2011/01/19 19:48:51, stuartmorgan wrote:
> Why rgb() for the backgrounds and hex for the border? It makes it hard to see
> how the colors relate, which is weird for colors that need to go together, so
it
> would be cleaner to change one or the other so they all match.

Done.