Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: chrome/browser/dom_ui/options/options_ui.cc

Issue 6344004: DOMUI: Move the meat of SyncOptionsHandler into PersonalOptionsHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/dom_ui/options/personal_options_handler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/dom_ui/options/options_ui.h" 5 #include "chrome/browser/dom_ui/options/options_ui.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <vector> 8 #include <vector>
9 9
10 #include "app/resource_bundle.h" 10 #include "app/resource_bundle.h"
11 #include "base/callback.h" 11 #include "base/callback.h"
(...skipping 17 matching lines...) Expand all
29 #include "chrome/browser/dom_ui/options/content_settings_handler.h" 29 #include "chrome/browser/dom_ui/options/content_settings_handler.h"
30 #include "chrome/browser/dom_ui/options/cookies_view_handler.h" 30 #include "chrome/browser/dom_ui/options/cookies_view_handler.h"
31 #include "chrome/browser/dom_ui/options/core_options_handler.h" 31 #include "chrome/browser/dom_ui/options/core_options_handler.h"
32 #include "chrome/browser/dom_ui/options/font_settings_handler.h" 32 #include "chrome/browser/dom_ui/options/font_settings_handler.h"
33 #include "chrome/browser/dom_ui/options/import_data_handler.h" 33 #include "chrome/browser/dom_ui/options/import_data_handler.h"
34 #include "chrome/browser/dom_ui/options/password_manager_handler.h" 34 #include "chrome/browser/dom_ui/options/password_manager_handler.h"
35 #include "chrome/browser/dom_ui/options/personal_options_handler.h" 35 #include "chrome/browser/dom_ui/options/personal_options_handler.h"
36 #include "chrome/browser/dom_ui/options/search_engine_manager_handler.h" 36 #include "chrome/browser/dom_ui/options/search_engine_manager_handler.h"
37 #include "chrome/browser/dom_ui/options/startup_page_manager_handler.h" 37 #include "chrome/browser/dom_ui/options/startup_page_manager_handler.h"
38 #include "chrome/browser/dom_ui/options/stop_syncing_handler.h" 38 #include "chrome/browser/dom_ui/options/stop_syncing_handler.h"
39 #include "chrome/browser/dom_ui/options/sync_options_handler.h"
40 #include "chrome/browser/metrics/user_metrics.h" 39 #include "chrome/browser/metrics/user_metrics.h"
41 #include "chrome/browser/renderer_host/render_view_host.h" 40 #include "chrome/browser/renderer_host/render_view_host.h"
42 #include "chrome/browser/profiles/profile.h" 41 #include "chrome/browser/profiles/profile.h"
43 #include "chrome/browser/tab_contents/tab_contents.h" 42 #include "chrome/browser/tab_contents/tab_contents.h"
44 #include "chrome/browser/tab_contents/tab_contents_delegate.h" 43 #include "chrome/browser/tab_contents/tab_contents_delegate.h"
45 #include "chrome/common/jstemplate_builder.h" 44 #include "chrome/common/jstemplate_builder.h"
46 #include "chrome/common/notification_type.h" 45 #include "chrome/common/notification_type.h"
47 #include "chrome/common/time_format.h" 46 #include "chrome/common/time_format.h"
48 #include "chrome/common/url_constants.h" 47 #include "chrome/common/url_constants.h"
49 #include "grit/browser_resources.h" 48 #include "grit/browser_resources.h"
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 AddOptionsPageUIHandler(localized_strings, new ClearBrowserDataHandler()); 152 AddOptionsPageUIHandler(localized_strings, new ClearBrowserDataHandler());
154 AddOptionsPageUIHandler(localized_strings, new ContentSettingsHandler()); 153 AddOptionsPageUIHandler(localized_strings, new ContentSettingsHandler());
155 AddOptionsPageUIHandler(localized_strings, new CookiesViewHandler()); 154 AddOptionsPageUIHandler(localized_strings, new CookiesViewHandler());
156 AddOptionsPageUIHandler(localized_strings, new FontSettingsHandler()); 155 AddOptionsPageUIHandler(localized_strings, new FontSettingsHandler());
157 AddOptionsPageUIHandler(localized_strings, new PasswordManagerHandler()); 156 AddOptionsPageUIHandler(localized_strings, new PasswordManagerHandler());
158 AddOptionsPageUIHandler(localized_strings, new PersonalOptionsHandler()); 157 AddOptionsPageUIHandler(localized_strings, new PersonalOptionsHandler());
159 AddOptionsPageUIHandler(localized_strings, new SearchEngineManagerHandler()); 158 AddOptionsPageUIHandler(localized_strings, new SearchEngineManagerHandler());
160 AddOptionsPageUIHandler(localized_strings, new StartupPageManagerHandler()); 159 AddOptionsPageUIHandler(localized_strings, new StartupPageManagerHandler());
161 AddOptionsPageUIHandler(localized_strings, new ImportDataHandler()); 160 AddOptionsPageUIHandler(localized_strings, new ImportDataHandler());
162 AddOptionsPageUIHandler(localized_strings, new StopSyncingHandler()); 161 AddOptionsPageUIHandler(localized_strings, new StopSyncingHandler());
163 AddOptionsPageUIHandler(localized_strings, new SyncOptionsHandler());
164 #if defined(OS_CHROMEOS) 162 #if defined(OS_CHROMEOS)
165 AddOptionsPageUIHandler(localized_strings, new AboutPageHandler()); 163 AddOptionsPageUIHandler(localized_strings, new AboutPageHandler());
166 AddOptionsPageUIHandler(localized_strings, 164 AddOptionsPageUIHandler(localized_strings,
167 new chromeos::AccountsOptionsHandler()); 165 new chromeos::AccountsOptionsHandler());
168 AddOptionsPageUIHandler(localized_strings, new InternetOptionsHandler()); 166 AddOptionsPageUIHandler(localized_strings, new InternetOptionsHandler());
169 AddOptionsPageUIHandler(localized_strings, 167 AddOptionsPageUIHandler(localized_strings,
170 new chromeos::LanguageChewingOptionsHandler()); 168 new chromeos::LanguageChewingOptionsHandler());
171 AddOptionsPageUIHandler(localized_strings, 169 AddOptionsPageUIHandler(localized_strings,
172 new chromeos::LanguageCustomizeModifierKeysHandler()); 170 new chromeos::LanguageCustomizeModifierKeysHandler());
173 AddOptionsPageUIHandler(localized_strings, 171 AddOptionsPageUIHandler(localized_strings,
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 OptionsPageUIHandler* handler_raw) { 269 OptionsPageUIHandler* handler_raw) {
272 scoped_ptr<OptionsPageUIHandler> handler(handler_raw); 270 scoped_ptr<OptionsPageUIHandler> handler(handler_raw);
273 DCHECK(handler.get()); 271 DCHECK(handler.get());
274 // Add only if handler's service is enabled. 272 // Add only if handler's service is enabled.
275 if (handler->IsEnabled()) { 273 if (handler->IsEnabled()) {
276 handler->GetLocalizedValues(localized_strings); 274 handler->GetLocalizedValues(localized_strings);
277 // Add handler to the list and also pass the ownership. 275 // Add handler to the list and also pass the ownership.
278 AddMessageHandler(handler.release()->Attach(this)); 276 AddMessageHandler(handler.release()->Attach(this));
279 } 277 }
280 } 278 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/dom_ui/options/personal_options_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698