Issue 6343005: Move stack check patching to the architecture dependent deoptimizer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6343005: Move stack check patching to the architecture dependent deoptimizer (Closed)

Created:
9 years, 11 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Move stack check patching to the architecture dependent deoptimizer files. On ARM it is not enough to iterate the relocation information because that will only give us access to the constant pool and not to the place in the instruction stream where the target in the constant pool is called. Committed: http://code.google.com/p/v8/source/detail?r=6444

Patch Set 1 #

Patch Set 2 : RevertStackCheckCode refactored as well. #

Total comments: 2

Patch Set 3 : Address comments. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -71 lines)			Patch
M	src/arm/deoptimizer-arm.cc	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/deoptimizer.h	View	1	1 chunk	+11 lines, -8 lines	0 comments	Download
M	src/ia32/deoptimizer-ia32.cc	View	1 2	1 chunk	+61 lines, -34 lines	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+3 lines, -9 lines	0 comments	Download
M	src/runtime-profiler.cc	View		1 chunk	+3 lines, -16 lines	0 comments	Download
M	src/x64/deoptimizer-x64.cc	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/6343005/diff/2001/src/ia32/deoptimizer-ia32.cc File src/ia32/deoptimizer-ia32.cc (right): http://codereview.chromium.org/6343005/diff/2001/src/ia32/deoptimizer-ia32.cc#newcode114 src/ia32/deoptimizer-ia32.cc:114: // check appears first i.e., is not deferred ...

9 years, 11 months ago (2011-01-24 14:47:06 UTC) #2

Mads Ager (chromium)

9 years, 11 months ago (2011-01-24 14:54:30 UTC) #3

http://codereview.chromium.org/6343005/diff/2001/src/ia32/deoptimizer-ia32.cc
File src/ia32/deoptimizer-ia32.cc (right):

http://codereview.chromium.org/6343005/diff/2001/src/ia32/deoptimizer-ia32.cc...
src/ia32/deoptimizer-ia32.cc:114: // check appears first i.e., is not deferred
or otherwise reordered.
On 2011/01/24 14:47:06, Søren Gjesse wrote:
> Assert unpotimized_code is not optimized?

Done.

Expand Messages | Collapse Messages