Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 6343003: [gtk] un-break status bubble. (Closed)

Created:
9 years, 11 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Visibility:
Public.

Description

[gtk] un-break status bubble. broken in r71858. BUG=70244 TEST=manual (in and out of --kiosk) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/ui/gtk/status_bubble_gtk.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Stade
9 years, 11 months ago (2011-01-20 19:52:22 UTC) #1
Elliot Glaysher
9 years, 11 months ago (2011-01-20 19:53:29 UTC) #2
LGTM

On Thu, Jan 20, 2011 at 11:52 AM,  <estade@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Description:
> [gtk] un-break status bubble.
>
> broken in r71858.
>
> BUG=70244
> TEST=manual (in and out of --kiosk)
>
> Please review this at http://codereview.chromium.org/6343003/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/ui/gtk/status_bubble_gtk.cc
>
>
> Index: chrome/browser/ui/gtk/status_bubble_gtk.cc
> diff --git a/chrome/browser/ui/gtk/status_bubble_gtk.cc
> b/chrome/browser/ui/gtk/status_bubble_gtk.cc
> index
>
79e607363463503c0a4eb2dc7ddee434ffef72f0..7f2dccb1e74853fbbd42bb3d6cff744abedad1ac
> 100644
> --- a/chrome/browser/ui/gtk/status_bubble_gtk.cc
> +++ b/chrome/browser/ui/gtk/status_bubble_gtk.cc
> @@ -115,7 +115,7 @@ void StatusBubbleGtk::Show() {
>   // If we were going to hide, stop.
>   hide_timer_.Stop();
>
> -  gtk_widget_show_all(container_.get());
> +  gtk_widget_show(container_.get());
>   if (container_->window)
>     gdk_window_raise(container_->window);
>  }
> @@ -125,7 +125,7 @@ void StatusBubbleGtk::Hide() {
>   expand_timer_.Stop();
>   expand_animation_.reset();
>
> -  gtk_widget_hide_all(container_.get());
> +  gtk_widget_hide(container_.get());
>  }
>
>  void StatusBubbleGtk::SetStatusTextTo(const std::string& status_utf8) {
> @@ -253,6 +253,7 @@ void StatusBubbleGtk::InitWidgets() {
>       kInternalLeftRightPadding + (ltr ? 0 : kCornerSize),
>       kInternalLeftRightPadding + (ltr ? kCornerSize : 0));
>   gtk_container_add(GTK_CONTAINER(padding_), label_);
> +  gtk_widget_show_all(padding_);
>
>   container_.Own(gtk_event_box_new());
>   gtk_widget_set_no_show_all(container_.get(), TRUE);
>
>
>

Powered by Google App Engine
This is Rietveld 408576698