Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 6343002: Fix a dumb error in the chrome frame tests code which attempts to terminate a... (Closed)

Created:
9 years, 11 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, amit, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix a dumb error in the chrome frame tests code which attempts to terminate any running browser processes on a crash. The exception handler was not registered correctly. BUG=none TEST=none TBR=amit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71658

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome_frame/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
9 years, 11 months ago (2011-01-18 14:45:40 UTC) #1
amit
9 years, 11 months ago (2011-01-18 16:43:26 UTC) #2
ok

On Tue, Jan 18, 2011 at 6:45 AM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Fix a dumb error in the chrome frame tests code which attempts to terminate
> any
> running
> browser processes on a crash. The exception handler was not registered
> correctly.
>
> BUG=none
> TEST=none
> TBR=amit
>
>
> Please review this at http://codereview.chromium.org/6343002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/run_all_unittests.cc
>
>
> Index: chrome_frame/test/run_all_unittests.cc
> ===================================================================
> --- chrome_frame/test/run_all_unittests.cc      (revision 71338)
> +++ chrome_frame/test/run_all_unittests.cc      (working copy)
> @@ -47,7 +47,7 @@
>       ret = base::TestSuite::Run();
>     }
>
> -    _except(EXCEPTION_EXECUTE_HANDLER) {
> +    __except(EXCEPTION_EXECUTE_HANDLER) {
>       ret = -1;
>     }
>     return ret;
>
>
>

Powered by Google App Engine
This is Rietveld 408576698