Added 'env' and 'ignore_sigint' to RunCommand.

Added 'env' and 'ignore_sigint' to RunCommand.

This updates the unit tests to test those features, too.

Change-Id: Ib77fad54acbb70a990d31140b6b2f941e861ca36

BUG=chromium-os:10948
TEST=Ran the unit tests; already using these functions in my own code.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=6781f94

[diandersAtChromium, 2011-01-14 00:34:11]

PTAL.  I can break this into two changes if people would prefer (one for the env
feature and one for the ignore_sigint feature).

sosa may have looked at this a little as part of this bigger change:
  http://codereview.chromium.org/6005004/

...but I didn't get any comments, so it's possible he missed it.  


-Doug

[davidjames, 2011-01-14 21:51:34]

LGTM w/nit

http://codereview.chromium.org/6343001/diff/1/lib/cros_build_lib.py
File lib/cros_build_lib.py (right):

http://codereview.chromium.org/6343001/diff/1/lib/cros_build_lib.py#newcode53
lib/cros_build_lib.py:53: child.  This is the desired behavior if we know our
child will handle
Only one space is needed after the period. Same below.

[diandersAtChromium, 2011-01-14 22:31:24]

David: I've uploaded a patch that uses only 1 space after periods, but was a
little uncertain about it.  See inline comment.

Thanks!

-Doug

http://codereview.chromium.org/6343001/diff/1/lib/cros_build_lib.py
File lib/cros_build_lib.py (right):

http://codereview.chromium.org/6343001/diff/1/lib/cros_build_lib.py#newcode53
lib/cros_build_lib.py:53: child.  This is the desired behavior if we know our
child will handle
Examples on google python style guide
<http://google-styleguide.googlecode.com/svn/trunk/pyguide.html> seem to be
inconsistent, so I'm curious where the 1 space rule comes from.  

Also: other examples in this file conform to the two space rule.  Do you want me
to change those, too?


On 2011/01/14 21:51:34, davidjames wrote:
> Only one space is needed after the period. Same below.

[diandersAtChromium, 2011-01-15 00:21:15]

Talked to davidjames.  He is fine w/ two spaces, and it's better to be locally
consistent.

On 2011/01/14 22:31:24, diandersAtChromium wrote:
> David: I've uploaded a patch that uses only 1 space after periods, but was a
> little uncertain about it.  See inline comment.
> 
> Thanks!
> 
> -Doug
> 
> http://codereview.chromium.org/6343001/diff/1/lib/cros_build_lib.py
> File lib/cros_build_lib.py (right):
> 
> http://codereview.chromium.org/6343001/diff/1/lib/cros_build_lib.py#newcode53
> lib/cros_build_lib.py:53: child.  This is the desired behavior if we know our
> child will handle
> Examples on google python style guide
> <http://google-styleguide.googlecode.com/svn/trunk/pyguide.html> seem to be
> inconsistent, so I'm curious where the 1 space rule comes from.  
> 
> Also: other examples in this file conform to the two space rule.  Do you want
me
> to change those, too?
> 
> 
> On 2011/01/14 21:51:34, davidjames wrote:
> > Only one space is needed after the period. Same below.