Issue 6342020: dom-ui settings: Layout tweaks to bring Under the Hood closer to mocks....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6342020: dom-ui settings: Layout tweaks to bring Under the Hood closer to mocks.... (Closed)

Created:
9 years, 11 months ago by csilv

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

dom-ui settings: Layout tweaks to bring Under the Hood closer to mocks. BUG=66114 TEST=Manual layout verification of Under the Hood panel. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72526

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -33 lines)			Patch
M	chrome/browser/dom_ui/options/advanced_options_handler.cc	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/options/advanced_options.css	View		1 chunk	+35 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/options/advanced_options.html	View		8 chunks	+31 lines, -28 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

csilv

+jhawkins for review Before & after screenshots: http://dl.dropbox.com/u/113552/UnderHood_before.png http://dl.dropbox.com/u/113552/UnderHood_after.png

9 years, 11 months ago (2011-01-25 19:19:51 UTC) #1

LGTM

Expand Messages | Collapse Messages