webkit/glue/media/buffered_data_source.h - Issue 6342018: Fix a teardown hang caused by an Abort() call while there is a pending read.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/glue/media/buffered_data_source.h

Issue 6342018: Fix a teardown hang caused by an Abort() call while there is a pending read. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/glue/media/buffered_data_source.h

diff --git a/webkit/glue/media/buffered_data_source.h b/webkit/glue/media/buffered_data_source.h

index c40b480258677a970a04a088ae9821688154d95f..25a565a97514391d183d3beeab92731d4cd33ddd 100644

--- a/webkit/glue/media/buffered_data_source.h

+++ b/webkit/glue/media/buffered_data_source.h

@@ -62,8 +62,7 @@ class BufferedDataSource : public WebDataSource {

void InitializeTask();

// Task posted to perform actual reading on the render thread.

- void ReadTask(int64 position, int read_size, uint8* read_buffer,

- media::DataSource::ReadCallback* read_callback);

+ void ReadTask(int64 position, int read_size, uint8* read_buffer);

// Task posted when Stop() is called. Stops |watch_dog_timer_| and

// |loader_|, reset Read() variables, and set |stopped_on_render_loop_|

« no previous file with comments | « no previous file | webkit/glue/media/buffered_data_source.cc » ('j') | webkit/glue/media/buffered_data_source_unittest.cc » ('J')