Issue 6342013: Fix the regression caused by r72061.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6342013: Fix the regression caused by r72061. (Closed)

Created:
9 years, 11 months ago by kochi

Modified:
9 years, 7 months ago

Reviewers:
tfarina, satorux1

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/browser/resources/options

Visibility:
Public.

Fix the regression caused by r72061. The CL ifdef'ed out for some parts of HTML, but it did not touch the corresponding JS code that modifies the part. BUG=chromium-os:11142 TEST=manually open chrome://settings Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72114

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	chrome/browser/resources/options/advanced_options.js	View	1	2 chunks	+8 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

tfarina

9 years, 11 months ago (2011-01-21 12:01:08 UTC) #3

On 2011/01/21 08:02:23, satorux1 wrote:
> LGTM

LGTM, thanks for fixing it.