Issue 6342012: ppapi_egl target is currently unused as verified by using:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6342012: ppapi_egl target is currently unused as verified by using:... (Closed)

Created:
9 years, 11 months ago by noelallen_use_chromium

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, neb, apatrick_chromium, bradn

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

ppapi_egl target is currently unused as verified by using: grep --include="*.gyp*" -nr -F "ppapi_egl" . However this library causes NaCl to require third_party/mesa which relative to NaCl is large. This CL moves the definition of this static library from ppapi to the lib/gl directory under ppapi so that PPAPI users are not forced to DEPS in mesa. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72090

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -40 lines)			Patch
	A	ppapi/lib/gl/gl.gyp	View	1 2	1 chunk	+55 lines, -0 lines	0 comments	Download
	M	ppapi/ppapi.gyp	View	2	2 chunks	+0 lines, -40 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bradn

http://codereview.chromium.org/6342012/diff/2001/ppapi/ppapi.gyp File ppapi/ppapi.gyp (right): http://codereview.chromium.org/6342012/diff/2001/ppapi/ppapi.gyp#newcode7 ppapi/ppapi.gyp:7: # This include forces PPAPI consumers to DEPS in ...

9 years, 11 months ago (2011-01-21 01:38:02 UTC) #1

LGTM2

Expand Messages | Collapse Messages