views: Remove views unittests from unit_tests executable.

views: Remove views unittests from unit_tests executable.

They were already moved to a separate executable called views_unittests.

(This was a TODO for jcampan).

BUG=64211
TEST=trybots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71914

[Jay Civelli, 2011-01-20 00:54:35]

LGTM

On Wed, Jan 19, 2011 at 3:02 PM,  <tfarina@chromium.org> wrote:
> Reviewers: Jay Civelli,
>
> Message:
> Hi Jay, could you review this to me?
>
> Description:
> views: Remove views unittests from unit_tests executable.
>
> They were already moved to a separate executable called views_unittests.
>
> (This was a TODO for jcampan).
>
> BUG=64211
> TEST=trybots
>
> Please review this at http://codereview.chromium.org/6342008/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/chrome_tests.gypi
>
>
> Index: chrome/chrome_tests.gypi
> diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi
> index
>
42d4756a49bbc062fb91f96abdc62f981cc4ba55..85c54304639af3f1f6d5a2796d72ddd1b79728f4
> 100644
> --- a/chrome/chrome_tests.gypi
> +++ b/chrome/chrome_tests.gypi
> @@ -1718,22 +1718,6 @@
>         'tools/convert_dict/convert_dict_unittest.cc',
>         '../testing/gtest_mac_unittest.mm',
>
>
'../third_party/cld/encodings/compact_lang_det/compact_lang_det_unittest_small.cc',
> -        # TODO(jcampan): Create a separate unit test for these to allow us
> to
> -        # test views completely decoupled from chrome.
> -        '../views/animation/bounds_animator_unittest.cc',
> -        '../views/box_layout_unittest.cc',
> -        '../views/controls/label_unittest.cc',
> -        '../views/controls/progress_bar_unittest.cc',
> -        '../views/controls/single_split_view.cc',
> -        '../views/controls/tabbed_pane/tabbed_pane_unittest.cc',
> -        '../views/controls/table/table_view_unittest.cc',
> -        '../views/controls/textfield/textfield_views_model_unittest.cc',
> -        '../views/controls/textfield/native_textfield_views_unittest.cc',
> -        '../views/focus/accelerator_handler_gtk_unittest.cc',
> -        '../views/focus/focus_manager_unittest.cc',
> -        '../views/grid_layout_unittest.cc',
> -        '../views/test/views_test_base.h',
> -        '../views/view_unittest.cc',
>       ],
>       'conditions': [
>         ['touchui==1', {
>
>
>

[oshima, 2011-01-20 03:45:30]

Can you revert this for now because views_unittets are not included in
chromiumos bots yet. Or if you can add it to chromiumos bots, that's also fine.

[tfarina, 2011-01-20 11:11:53]

On 2011/01/20 03:45:30, oshima wrote:
> Can you revert this for now because views_unittets are not included in
> chromiumos bots yet. Or if you can add it to chromiumos bots, that's also
fine.

I asked Jay about the chromeos bot before doing this change.