Issue 6341015: Fix some bugs with incorrect ! (both missing and extra) in the proxy error ha...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6341015: Fix some bugs with incorrect ! (both missing and extra) in the proxy error ha... (Closed)

Created:
9 years, 11 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix some bugs with incorrect ! (both missing and extra) in the proxy error handling. Go back to using the old code for the audio created notification. There was a bug deserializing one of the handles, and the new code I wrote didn't turn out to be necessary anyway. TEST=audio plays in out-of-process proxy (manual) BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73003

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -60 lines)			Patch
M	ppapi/proxy/ppapi_messages_internal.h	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppapi_param_traits.h	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	ppapi/proxy/ppapi_param_traits.cc	View	1 chunk	+0 lines, -30 lines	0 comments	Download
M	ppapi/proxy/ppb_audio_config_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/ppb_audio_proxy.h	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	ppapi/proxy/ppb_audio_proxy.cc	View	2 chunks	+12 lines, -14 lines	0 comments	Download
M	ppapi/proxy/ppb_font_proxy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages