Issue 6341013: Put geolocation unit and browser test code in anonymous namespaces to avoid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6341013: Put geolocation unit and browser test code in anonymous namespaces to avoid (Closed)

Created:
9 years, 11 months ago by John Knottenbelt

Modified:
9 years, 7 months ago

Reviewers:
hans

CC:
chromium-reviews, Paweł Hajdan Jr., bulach

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Put geolocation unit and browser test code in anonymous namespaces. Avoid overlapping class definitions (e.g. MessageLoopQuitListener). BUG=None TEST=unit_tests,browser_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72793

Patch Set 1 #

Patch Set 2 : Source files need to end in a newline. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -5 lines)			Patch
M	chrome/browser/geolocation/access_token_store_browsertest.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/geolocation/device_data_provider_unittest.cc	View	1	3 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/geolocation/gateway_data_provider_common_unittest.cc	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_browsertest.cc	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_exceptions_table_model_unittest.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/geolocation/geolocation_permission_context_unittest.cc	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/geolocation/network_location_provider_unittest.cc	View	1	3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/geolocation/wifi_data_provider_common_unittest.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/geolocation/win7_location_api_unittest_win.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/geolocation/win7_location_provider_unittest_win.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

hans

9 years, 11 months ago (2011-01-27 12:01:03 UTC) #2

On 2011/01/27 11:44:39, John Knottenbelt wrote:

LGTM except for the red try bots.

ship it when they're green :)

Expand Messages | Collapse Messages