Issue 6341008: Refactor recording of safepoints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6341008: Refactor recording of safepoints. (Closed)

Created:
9 years, 11 months ago by Karl Klose

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Refactor recording of safepoints. Refactor SafepointTableBuilder::DefineSafepoint and ARM LCodeGen::RecordSafepoint to use an enum for different kinds of safepoints. This change removes a lot of duplicated code and makes it easier to include new kinds of safepoints in the future. The remaining variants of LCodeGen::RecordSafepoint remain as a convinient way to record common safepoint kinds. BUG=http://code.google.com/p/v8/issues/detail?id=1043 TEST=none

Patch Set 1 #

Patch Set 2 : Implementation for ia32 and x64 platforms. #

Patch Set 3 : Fix presubmit. #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -118 lines)			Patch
M	src/arm/lithium-codegen-arm.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 2	2 chunks	+22 lines, -31 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 2	1 chunk	+20 lines, -17 lines	0 comments	Download
M	src/safepoint-table.h	View		2 chunks	+8 lines, -17 lines	0 comments	Download
M	src/safepoint-table.cc	View	1 2	2 chunks	+7 lines, -36 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 2	1 chunk	+20 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages