Issue 6341002: Removed executable bit from two files where it should not have been set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6341002: Removed executable bit from two files where it should not have been set. (Closed)

Created:
9 years, 11 months ago by levin

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Removed executable bit from two files where it should not have been set. TBR=ben@chromium.org TEST=check perms test BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71504

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-2 lines, --2 lines)			Patch
	A	views/widget/widget_win.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
	A	views/widget/widget_win_unittest.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

9 years, 11 months ago (2011-01-18 16:53:47 UTC) #2

OK

On Fri, Jan 14, 2011 at 2:44 PM, <levin@chromium.org> wrote:

> Reviewers: Ben Goodger,
>
> Description:
> Removed executable bit from two files where it should not have been set.
>
> TBR=ben@chromium.org
> TEST=check perms test
> BUG=None
>
> Please review this at http://codereview.chromium.org/6341002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  A views/widget/widget_win.cc
>  A views/widget/widget_win_unittest.cc
>
>
> Index: views/widget/widget_win.cc
> diff --git a/views/widget/widget_win.cc b/views/widget/widget_win.cc
> old mode 100755
> new mode 100644
> Index: views/widget/widget_win_unittest.cc
> diff --git a/views/widget/widget_win_unittest.cc
> b/views/widget/widget_win_unittest.cc
> old mode 100755
> new mode 100644
>
>
>

Expand Messages | Collapse Messages