Issue 6341: Improve the generated code for the instanceof operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6341: Improve the generated code for the instanceof operator. (Closed)

Created:
12 years, 2 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Improve the generated code for the instanceof operator, and extended the instanceof test case. Committed: http://code.google.com/p/v8/source/detail?r=470

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+137 lines, -78 lines)			Patch
M	src/code-stubs.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/code-stubs.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/codegen-arm.cc	View	5 chunks	+2 lines, -9 lines	0 comments	Download
M	src/codegen-ia32.cc	View	8 chunks	+63 lines, -20 lines	0 comments	Download
M	src/macro-assembler-ia32.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/macro-assembler-ia32.cc	View	2 chunks	+51 lines, -2 lines	1 comment	Download
M	src/runtime.js	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	src/stub-cache-ia32.cc	View	1 chunk	+1 line, -43 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

12 years, 2 months ago (2008-10-08 13:29:08 UTC) #2

LGTM (hairy stuff!)

http://codereview.chromium.org/6341/diff/1/2
File src/macro-assembler-ia32.cc (right):

http://codereview.chromium.org/6341/diff/1/2#newcode595
Line 595: test(function, Immediate(kSmiTagMask));
We normally have an assert here in case we ever decide to tag smis with a 1

Expand Messages | Collapse Messages