Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: chrome/browser/autocomplete/autocomplete.cc

Issue 6340012: Fix a DCHECK failure in AutocompleteEditModel::OnPopupDataChanged() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete.cc
diff --git a/chrome/browser/autocomplete/autocomplete.cc b/chrome/browser/autocomplete/autocomplete.cc
index ab47a127a44cba3023e660dd27cd0a025ee68b0f..6a0711e4e9559bc634d83e10271b003bd6adcf14 100644
--- a/chrome/browser/autocomplete/autocomplete.cc
+++ b/chrome/browser/autocomplete/autocomplete.cc
@@ -795,9 +795,11 @@ void AutocompleteController::DeleteMatch(const AutocompleteMatch& match) {
DCHECK(match.deletable);
match.provider->DeleteMatch(match); // This may synchronously call back to
// OnProviderUpdate().
+ DCHECK(updated_latest_result_);
CommitResult(true); // Ensure any new result gets committed immediately. If
// it was committed already or hasn't been modified, this
- // is harmless.
+ // is harmless. We need to notify the edit box, because
+ // the default match may have been changed.
}
void AutocompleteController::CommitIfQueryHasNeverBeenCommitted() {

Powered by Google App Engine
This is Rietveld 408576698