Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 6340004: Linux: --single-process with GPU acceleration. (Closed)

Created:
9 years, 11 months ago by jonathan.backer
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Alexey Marinichev, apatrick_chromium
Visibility:
Public.

Description

The GPU process cannot be placed on a UI thread in --single-process mode because glib is not thread safe. This patch moves it onto a IO thread instead. Connections to the X server are not thread safe. I've made changes so that each thread gets it's own connection. Finally, GpuHostMsg_GetViewXID needed to be needed to be sent from the thread added to GpuChannel instead of ChildThread::current(). BUG=69674 TEST=try --single-process with --enable-accelerated-layers on http://webkit.org/blog/386/3d-transforms/ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71655

Patch Set 1 #

Patch Set 2 : Linter. #

Patch Set 3 : Try rebasing off of ToT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -22 lines) Patch
M app/gfx/gl/gl_context_egl.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M app/gfx/gl/gl_context_linux.cc View 1 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/gpu_process_host.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M chrome/gpu/gpu_channel.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jonathan.backer
Having some trouble with the try bots. They don't like the patch (even though I've ...
9 years, 11 months ago (2011-01-14 22:03:15 UTC) #1
apatrick_chromium
LGTM once you get the trybots working. Thanks for fixing it.
9 years, 11 months ago (2011-01-14 22:50:06 UTC) #2
amarinichev
Works now, thanks! On Fri, Jan 14, 2011 at 2:50 PM, <apatrick@chromium.org> wrote: > LGTM ...
9 years, 11 months ago (2011-01-14 23:15:54 UTC) #3
jonathan.backer
9 years, 11 months ago (2011-01-17 16:28:27 UTC) #4
On 2011/01/14 22:50:06, apatrick_chromium wrote:
> LGTM once you get the trybots working. Thanks for fixing it.

Problem with the trybots was that LKGR is lagging way behind ToT. By specifying
an appropriate --revision, everything seems to work.

Powered by Google App Engine
This is Rietveld 408576698