Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 6339018: Revert "Have the ability for the PFQ to both rev Chrome and ..." (Closed)

Created:
9 years, 11 months ago by Vincent Palatin
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Revert "Have the ability for the PFQ to both rev Chrome and ..." This reverts the commit a8ac0ec8c3fd481c48e3846a8dfcae8105bab14a. TBR the x86 PFQ buildbot fails BUG=chromium-os:11447 TEST= TBR=sosa Change-Id: I019de669db13b753365e1208acc9923c4bb5c993 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3eb3543

Patch Set 1 #

Patch Set 2 : Put the right revert patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -81 lines) Patch
M bin/cbuildbot.py View 3 chunks +10 lines, -10 lines 0 comments Download
M bin/cbuildbot_config.py View 5 chunks +10 lines, -13 lines 0 comments Download
M bin/cros_mark_chrome_as_stable.py View 1 chunk +12 lines, -6 lines 0 comments Download
M cros_mark_as_stable.py View 7 chunks +25 lines, -31 lines 0 comments Download
M cros_mark_as_stable_unittest.py View 2 chunks +40 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vincent Palatin
We might need to revert it , it seems to make the x86 PFQ fail
9 years, 11 months ago (2011-01-28 20:36:02 UTC) #1
kliegs
Please add the Treecloser bug to the BUG= line Otherwise LGTM On Fri, Jan 28, ...
9 years, 11 months ago (2011-01-28 20:43:52 UTC) #2
sosa
Yeah not convinced this did it but sure why not. Seems like cleaning up chromiumos-overlay ...
9 years, 11 months ago (2011-01-28 21:05:25 UTC) #3
dgarrett
9 years, 11 months ago (2011-01-28 21:16:40 UTC) #4
I think that a test run of a change to cbuildbot on my workstation tried to
uprev the package versions. This confused and broken the build server. I was
running with --debug, which is supposed to stop the script from trying to
push the uprevs, but I'm thinking there is a bug with --debug. If you want,
give me the bug for the build break, and I'll use it to track work fixing
the --debug problem.

On Fri, Jan 28, 2011 at 1:05 PM, Chris Sosa <sosa@chromium.org> wrote:

> Yeah not convinced this did it but sure why not.  Seems like cleaning
> up chromiumos-overlay fixed the issue.  I don't think this CL actually
> mucked that repo.
>
> On Fri, Jan 28, 2011 at 12:43 PM, Jonathan Kliegman <kliegs@chromium.org>
> wrote:
> > Please add the Treecloser bug to the BUG= line
> > Otherwise LGTM
> >
> > On Fri, Jan 28, 2011 at 3:36 PM, <vpalatin@chromium.org> wrote:
> >>
> >> Reviewers: sosa, kliegs, rharrison, dgarrett, kuan,
> >>
> >> Message:
> >> We might need to revert it , it seems to make the x86 PFQ fail
> >>
> >> Description:
> >> Revert "Have the ability for the PFQ to both rev Chrome and ..."
> >>
> >> This reverts the commit a8ac0ec8c3fd481c48e3846a8dfcae8105bab14a.
> >>
> >> TBR the x86 PFQ buildbot fails
> >>
> >> BUG=
> >> TEST=
> >> TBR=sosa
> >>
> >> Change-Id: I019de669db13b753365e1208acc9923c4bb5c993
> >>
> >> Please review this at http://codereview.chromium.org/6339018/
> >>
> >> SVN Base: ssh://git@gitrw.chromium.org:9222/crosutils.git@master
> >>
> >> Affected files:
> >>  M bin/cbuildbot.py
> >>  M bin/cbuildbot_config.py
> >>  M bin/cros_mark_chrome_as_stable.py
> >>  M cros_mark_as_stable.py
> >>  M cros_mark_as_stable_unittest.py
> >>
> >>
> >
> >
>



-- 
Don

Powered by Google App Engine
This is Rietveld 408576698