Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 6339014: Fix issue 1076 by resetting labels of switch-clauses before use.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 692 matching lines...) Expand 10 before | Expand all | Expand 10 after
703 VisitForStackValue(stmt->tag()); 703 VisitForStackValue(stmt->tag());
704 PrepareForBailoutForId(stmt->EntryId(), NO_REGISTERS); 704 PrepareForBailoutForId(stmt->EntryId(), NO_REGISTERS);
705 705
706 ZoneList<CaseClause*>* clauses = stmt->cases(); 706 ZoneList<CaseClause*>* clauses = stmt->cases();
707 CaseClause* default_clause = NULL; // Can occur anywhere in the list. 707 CaseClause* default_clause = NULL; // Can occur anywhere in the list.
708 708
709 Label next_test; // Recycled for each test. 709 Label next_test; // Recycled for each test.
710 // Compile all the tests with branches to their bodies. 710 // Compile all the tests with branches to their bodies.
711 for (int i = 0; i < clauses->length(); i++) { 711 for (int i = 0; i < clauses->length(); i++) {
712 CaseClause* clause = clauses->at(i); 712 CaseClause* clause = clauses->at(i);
713 clause->body_target()->entry_label()->Unuse();
714
713 // The default is not a test, but remember it as final fall through. 715 // The default is not a test, but remember it as final fall through.
714 if (clause->is_default()) { 716 if (clause->is_default()) {
715 default_clause = clause; 717 default_clause = clause;
716 continue; 718 continue;
717 } 719 }
718 720
719 Comment cmnt(masm_, "[ Case comparison"); 721 Comment cmnt(masm_, "[ Case comparison");
720 __ bind(&next_test); 722 __ bind(&next_test);
721 next_test.Unuse(); 723 next_test.Unuse();
722 724
(...skipping 2919 matching lines...) Expand 10 before | Expand all | Expand 10 after
3642 __ ret(0); 3644 __ ret(0);
3643 } 3645 }
3644 3646
3645 3647
3646 #undef __ 3648 #undef __
3647 3649
3648 3650
3649 } } // namespace v8::internal 3651 } } // namespace v8::internal
3650 3652
3651 #endif // V8_TARGET_ARCH_X64 3653 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698