Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 6339014: Fix issue 1076 by resetting labels of switch-clauses before use.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 746 matching lines...) Expand 10 before | Expand all | Expand 10 after
757 VisitForStackValue(stmt->tag()); 757 VisitForStackValue(stmt->tag());
758 PrepareForBailoutForId(stmt->EntryId(), NO_REGISTERS); 758 PrepareForBailoutForId(stmt->EntryId(), NO_REGISTERS);
759 759
760 ZoneList<CaseClause*>* clauses = stmt->cases(); 760 ZoneList<CaseClause*>* clauses = stmt->cases();
761 CaseClause* default_clause = NULL; // Can occur anywhere in the list. 761 CaseClause* default_clause = NULL; // Can occur anywhere in the list.
762 762
763 Label next_test; // Recycled for each test. 763 Label next_test; // Recycled for each test.
764 // Compile all the tests with branches to their bodies. 764 // Compile all the tests with branches to their bodies.
765 for (int i = 0; i < clauses->length(); i++) { 765 for (int i = 0; i < clauses->length(); i++) {
766 CaseClause* clause = clauses->at(i); 766 CaseClause* clause = clauses->at(i);
767 clause->body_target()->entry_label()->Unuse();
768
767 // The default is not a test, but remember it as final fall through. 769 // The default is not a test, but remember it as final fall through.
768 if (clause->is_default()) { 770 if (clause->is_default()) {
769 default_clause = clause; 771 default_clause = clause;
770 continue; 772 continue;
771 } 773 }
772 774
773 Comment cmnt(masm_, "[ Case comparison"); 775 Comment cmnt(masm_, "[ Case comparison");
774 __ bind(&next_test); 776 __ bind(&next_test);
775 next_test.Unuse(); 777 next_test.Unuse();
776 778
(...skipping 3587 matching lines...) Expand 10 before | Expand all | Expand 10 after
4364 // And return. 4366 // And return.
4365 __ ret(0); 4367 __ ret(0);
4366 } 4368 }
4367 4369
4368 4370
4369 #undef __ 4371 #undef __
4370 4372
4371 } } // namespace v8::internal 4373 } } // namespace v8::internal
4372 4374
4373 #endif // V8_TARGET_ARCH_IA32 4375 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698