Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 6339012: More net/ method ordering. (Closed)

Created:
9 years, 11 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

More net/ method ordering. BUG=68682 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72710

Patch Set 1 #

Patch Set 2 : More done while waiting for previous patch to clear #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3275 lines, -3238 lines) Patch
M net/base/upload_data.cc View 1 2 chunks +12 lines, -12 lines 0 comments Download
M net/base/upload_data_stream.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M net/base/x509_certificate.cc View 1 3 chunks +34 lines, -34 lines 0 comments Download
M net/disk_cache/backend_impl.cc View 1 2 chunks +27 lines, -29 lines 0 comments Download
M net/disk_cache/file_posix.cc View 1 3 chunks +18 lines, -18 lines 0 comments Download
M net/disk_cache/mapped_file_posix.cc View 1 2 chunks +10 lines, -10 lines 0 comments Download
M net/disk_cache/rankings.cc View 1 3 chunks +162 lines, -162 lines 0 comments Download
M net/disk_cache/stats.cc View 1 4 chunks +89 lines, -89 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_vms.h View 2 chunks +7 lines, -5 lines 0 comments Download
M net/ftp/ftp_network_transaction.h View 3 chunks +33 lines, -31 lines 0 comments Download
M net/ftp/ftp_network_transaction.cc View 7 chunks +117 lines, -117 lines 0 comments Download
M net/http/disk_cache_based_ssl_host_info.h View 3 chunks +9 lines, -15 lines 0 comments Download
M net/http/disk_cache_based_ssl_host_info.cc View 8 chunks +105 lines, -87 lines 0 comments Download
M net/http/http_auth_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_auth_filter.cc View 2 chunks +15 lines, -15 lines 0 comments Download
M net/http/http_auth_handler_digest.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_auth_handler_digest.cc View 3 chunks +160 lines, -160 lines 0 comments Download
M net/http/http_auth_handler_mock.h View 3 chunks +28 lines, -26 lines 0 comments Download
M net/http/http_auth_handler_mock.cc View 2 chunks +11 lines, -7 lines 0 comments Download
M net/http/http_auth_handler_negotiate.h View 3 chunks +12 lines, -13 lines 0 comments Download
M net/http/http_auth_handler_negotiate.cc View 4 chunks +156 lines, -156 lines 0 comments Download
M net/http/http_auth_handler_ntlm.h View 2 chunks +4 lines, -4 lines 0 comments Download
M net/http/http_auth_handler_ntlm.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M net/http/http_auth_handler_ntlm_portable.cc View 4 chunks +16 lines, -16 lines 0 comments Download
M net/http/http_basic_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_cache_transaction.h View 3 chunks +19 lines, -19 lines 0 comments Download
M net/http/http_cache_transaction.cc View 2 chunks +64 lines, -64 lines 0 comments Download
M net/http/http_network_layer.h View 3 chunks +7 lines, -6 lines 0 comments Download
M net/http/http_network_layer.cc View 3 chunks +81 lines, -77 lines 0 comments Download
M net/http/http_request_headers.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M net/http/mock_gssapi_library_posix.h View 2 chunks +51 lines, -52 lines 0 comments Download
M net/http/mock_gssapi_library_posix.cc View 2 chunks +17 lines, -17 lines 0 comments Download
M net/proxy/proxy_list.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M net/socket/client_socket.cc View 2 chunks +36 lines, -36 lines 0 comments Download
M net/socket/client_socket_factory.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M net/socket/dns_cert_provenance_checker.cc View 3 chunks +24 lines, -24 lines 0 comments Download
M net/socket/ssl_client_socket_nss.h View 5 chunks +17 lines, -15 lines 0 comments Download
M net/socket/ssl_client_socket_nss.cc View 7 chunks +1556 lines, -1557 lines 0 comments Download
M net/socket/ssl_server_socket_nss.h View 4 chunks +9 lines, -8 lines 0 comments Download
M net/socket/ssl_server_socket_nss.cc View 5 chunks +118 lines, -110 lines 0 comments Download
M net/test/test_server.cc View 1 4 chunks +43 lines, -43 lines 0 comments Download
M net/url_request/url_request_about_job.h View 1 chunk +4 lines, -3 lines 0 comments Download
M net/url_request/url_request_about_job.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M net/url_request/url_request_context.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/url_request/url_request_file_dir_job.h View 2 chunks +5 lines, -3 lines 0 comments Download
M net/url_request/url_request_file_dir_job.cc View 5 chunks +33 lines, -33 lines 0 comments Download
M net/url_request/url_request_file_job.h View 2 chunks +7 lines, -6 lines 0 comments Download
M net/url_request/url_request_file_job.cc View 5 chunks +79 lines, -79 lines 0 comments Download
M net/url_request/url_request_job_manager.h View 2 chunks +10 lines, -10 lines 0 comments Download
M net/url_request/url_request_job_manager.cc View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
This patch is boring. Nothing but moving methods around. (It's also the last reordering one ...
9 years, 11 months ago (2011-01-26 22:07:21 UTC) #1
willchan no longer on Chromium
9 years, 11 months ago (2011-01-26 22:42:58 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698