Issue 6339007: Slightly better docs for the convert_dict tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6339007: Slightly better docs for the convert_dict tool. (Closed)

Created:
9 years, 11 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Slightly better docs for the convert_dict tool. BUG=none TEST=none committed in r72051

Patch Set 2 : no dollar bill #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/tools/convert_dict/convert_dict.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

LGTM! http://codereview.chromium.org/6339007/diff/1/chrome/tools/convert_dict/convert_dict.cc File chrome/tools/convert_dict/convert_dict.cc (right): http://codereview.chromium.org/6339007/diff/1/chrome/tools/convert_dict/convert_dict.cc#newcode79 chrome/tools/convert_dict/convert_dict.cc:79: printf(" $ convert_dict en-US\nwill read en-US.dic, en-US.dic_delta, and ...

9 years, 11 months ago (2011-01-20 23:49:57 UTC) #2

Evan Stade

9 years, 11 months ago (2011-01-21 00:16:57 UTC) #3

On 2011/01/20 23:49:57, brettw wrote:
> LGTM!
> 
>
http://codereview.chromium.org/6339007/diff/1/chrome/tools/convert_dict/conve...
> File chrome/tools/convert_dict/convert_dict.cc (right):
> 
>
http://codereview.chromium.org/6339007/diff/1/chrome/tools/convert_dict/conve...
> chrome/tools/convert_dict/convert_dict.cc:79: printf("  $ convert_dict
> en-US\nwill read en-US.dic, en-US.dic_delta, and "
> The addition of $ is confusing here since I normally ran it on Windows. Maybe
> it's OK without it?

ok

Expand Messages | Collapse Messages

Issue 6339007: Slightly better docs for the convert_dict tool. (Closed)

Description

Patch Set 1 #

Patch Set 2 : no dollar bill #

Messages