Add run-time enable support for the web audio API...

Add run-time enable support for the web audio API
BUG=none
TEST=none
(tested locally on Mac OS X to verify about:flags shows the web audio feature and that it can be enabled/disabled)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72261

[Chris Rogers, 2011-01-19 22:27:48]

Please also see companion WebKit patch:
https://bugs.webkit.org/process_bug.cgi

[darin (slow to review), 2011-01-19 23:32:43]

http://codereview.chromium.org/6339004/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

http://codereview.chromium.org/6339004/diff/1/chrome/browser/about_flags.cc#n...
chrome/browser/about_flags.cc:287: kOsMac,  // FIXME(crogers): add windows and
linux when FFT is ready.
in chromium, we use TODO instead of FIXME

http://codereview.chromium.org/6339004/diff/1/chrome/common/chrome_switches.cc
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/6339004/diff/1/chrome/common/chrome_switches.c...
chrome/common/chrome_switches.cc:414: const char kEnableWebAudio[]     =
"enable-webaudio";
nit: please follow the indentation style for the rvalue.  please also be sure to
insert this item so that it appears in the same order as it does in the header
file relative to other flags.

http://codereview.chromium.org/6339004/diff/1/chrome/common/chrome_switches.h
File chrome/common/chrome_switches.h (right):

http://codereview.chromium.org/6339004/diff/1/chrome/common/chrome_switches.h...
chrome/common/chrome_switches.h:127: extern const char kEnableWebAudio[];
nit: please insert this flag in alphabetical order.

[darin (slow to review), 2011-01-19 23:36:29]

You also need to update ParamTraits<WebPreferences>::Write and  Read methods in
render_messages.cc!

[Chris Rogers, 2011-01-20 00:08:27]

I've addressed the style comments.

http://codereview.chromium.org/6339004/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

http://codereview.chromium.org/6339004/diff/1/chrome/browser/about_flags.cc#n...
chrome/browser/about_flags.cc:287: kOsMac,  // FIXME(crogers): add windows and
linux when FFT is ready.
On 2011/01/19 23:32:43, darin wrote:
> in chromium, we use TODO instead of FIXME

Done.

http://codereview.chromium.org/6339004/diff/1/chrome/common/chrome_switches.cc
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/6339004/diff/1/chrome/common/chrome_switches.c...
chrome/common/chrome_switches.cc:414: const char kEnableWebAudio[]     =
"enable-webaudio";
On 2011/01/19 23:32:43, darin wrote:
> nit: please follow the indentation style for the rvalue.  please also be sure
to
> insert this item so that it appears in the same order as it does in the header
> file relative to other flags.

Done.

http://codereview.chromium.org/6339004/diff/1/chrome/common/chrome_switches.h
File chrome/common/chrome_switches.h (right):

http://codereview.chromium.org/6339004/diff/1/chrome/common/chrome_switches.h...
chrome/common/chrome_switches.h:127: extern const char kEnableWebAudio[];
On 2011/01/19 23:32:43, darin wrote:
> nit: please insert this flag in alphabetical order.

Done.

[Chris Rogers, 2011-01-20 00:30:48]

This last patch deals with ParamTraits<WebPreferences>::Write and Read methods.

[darin (slow to review), 2011-01-20 17:02:02]

LGTM