Command-line tool to generate a newly versioned mini_installer.exe

- upgrade_test::GenerateNextVersion is now GenerateAlternateVersion and can bump up or down
- upgrade_test::GenerateAlternateVersion returns the old and new versions
- added alternate_version_generator.exe command-line tool.

BUG=none
TEST=run alternate_version_generator.exe --help and explore it

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72993

[grt (UTC plus 2), 2011-01-28 16:49:53]

http://codereview.chromium.org/6338020/diff/11001/chrome/installer/test/alter...
File chrome/installer/test/alternate_version_generator_main.cc (right):

http://codereview.chromium.org/6338020/diff/11001/chrome/installer/test/alter...
chrome/installer/test/alternate_version_generator_main.cc:77: L"
--mini_installer=SRC_PATH  Relative or absolute path to mini_installer.exe.\n" 
// NOLINT
some of these are longer than 80 cols since the text is formatted to wrap at 80
when displayed.  should i 1) leave them as-is, 2) reformat the text to wrap
sooner so that the strings fit in 80 cols, or 3) wrap the strings as-is so that
the strings in the source code don't wrap at the same points as the program
output?

[robertshield, 2011-01-28 18:36:22]

LG, some nits

http://codereview.chromium.org/6338020/diff/11001/chrome/installer/test/alter...
File chrome/installer/test/alternate_version_generator_main.cc (right):

http://codereview.chromium.org/6338020/diff/11001/chrome/installer/test/alter...
chrome/installer/test/alternate_version_generator_main.cc:22: const wchar_t
kMiniInstallerExe[] = L"mini_installer.exe";
Have the word "default" in the names of these two constants to imply that they
are used in the absence of any overriding input?

http://codereview.chromium.org/6338020/diff/11001/chrome/installer/test/alter...
chrome/installer/test/alternate_version_generator_main.cc:74: L"Usage: %s [
--mini_installer=SRC_PATH ] [--out=OUT_PATH ] [ --previous ]\n"
Does this line wrap properly on the command line? I figured the program name
would be longer than 8 characters.

http://codereview.chromium.org/6338020/diff/11001/chrome/installer/test/alter...
chrome/installer/test/alternate_version_generator_main.cc:77: L"
--mini_installer=SRC_PATH  Relative or absolute path to mini_installer.exe.\n" 
// NOLINT
On 2011/01/28 16:49:53, grt wrote:
> some of these are longer than 80 cols since the text is formatted to wrap at
80
> when displayed.  should i 1) leave them as-is, 2) reformat the text to wrap
> sooner so that the strings fit in 80 cols, or 3) wrap the strings as-is so
that
> the strings in the source code don't wrap at the same points as the program
> output?

Prefer 2) as the option that provides the most readability both on the command
line and in the source code.

http://codereview.chromium.org/6338020/diff/11001/chrome/installer/test/alter...
chrome/installer/test/alternate_version_generator_main.cc:95: FilePath*
mini_installer) {
DCHECK(mini_installer)

http://codereview.chromium.org/6338020/diff/11001/chrome/installer/test/alter...
chrome/installer/test/alternate_version_generator_main.cc:106: void
GetOutPath(const CommandLine& cmd_line, FilePath* out) {
DCHECK(out)

http://codereview.chromium.org/6338020/diff/11001/chrome/installer/upgrade_te...
File chrome/installer/upgrade_test.gyp (right):

http://codereview.chromium.org/6338020/diff/11001/chrome/installer/upgrade_te...
chrome/installer/upgrade_test.gyp:1: {
This file needs a license header at the top.

[grt (UTC plus 2), 2011-01-28 19:13:33]

PTAL; thanks.

http://codereview.chromium.org/6338020/diff/11001/chrome/installer/test/alter...
File chrome/installer/test/alternate_version_generator_main.cc (right):

http://codereview.chromium.org/6338020/diff/11001/chrome/installer/test/alter...
chrome/installer/test/alternate_version_generator_main.cc:22: const wchar_t
kMiniInstallerExe[] = L"mini_installer.exe";
On 2011/01/28 18:36:22, robertshield wrote:
> Have the word "default" in the names of these two constants to imply that they
> are used in the absence of any overriding input?

Done.

http://codereview.chromium.org/6338020/diff/11001/chrome/installer/test/alter...
chrome/installer/test/alternate_version_generator_main.cc:74: L"Usage: %s [
--mini_installer=SRC_PATH ] [--out=OUT_PATH ] [ --previous ]\n"
On 2011/01/28 18:36:22, robertshield wrote:
> Does this line wrap properly on the command line? I figured the program name
> would be longer than 8 characters.

Done.

http://codereview.chromium.org/6338020/diff/11001/chrome/installer/test/alter...
chrome/installer/test/alternate_version_generator_main.cc:77: L"
--mini_installer=SRC_PATH  Relative or absolute path to mini_installer.exe.\n" 
// NOLINT
On 2011/01/28 18:36:22, robertshield wrote:
> On 2011/01/28 16:49:53, grt wrote:
> > some of these are longer than 80 cols since the text is formatted to wrap at
> 80
> > when displayed.  should i 1) leave them as-is, 2) reformat the text to wrap
> > sooner so that the strings fit in 80 cols, or 3) wrap the strings as-is so
> that
> > the strings in the source code don't wrap at the same points as the program
> > output?
> 
> Prefer 2) as the option that provides the most readability both on the command
> line and in the source code.

Done.

http://codereview.chromium.org/6338020/diff/11001/chrome/installer/test/alter...
chrome/installer/test/alternate_version_generator_main.cc:95: FilePath*
mini_installer) {
On 2011/01/28 18:36:22, robertshield wrote:
> DCHECK(mini_installer)

Done.

http://codereview.chromium.org/6338020/diff/11001/chrome/installer/test/alter...
chrome/installer/test/alternate_version_generator_main.cc:106: void
GetOutPath(const CommandLine& cmd_line, FilePath* out) {
On 2011/01/28 18:36:22, robertshield wrote:
> DCHECK(out)

Done.

[robertshield, 2011-01-28 19:19:57]

LGTM