Issue 6338014: Comment out broken CHECK in ppapi/ppb_url_loader_impl.cc....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6338014: Comment out broken CHECK in ppapi/ppb_url_loader_impl.cc.... (Closed)

Created:
9 years, 11 months ago by polina

Modified:
9 years, 7 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Comment out broken CHECK in ppapi/ppb_url_loader_impl.cc. BUG=70347 TESTED=bots + used nacl with ppapi_geturl that uncovered the crash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72229

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	webkit/plugins/ppapi/ppb_url_loader_impl.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

LGTM with trivial nit fixed. Thanks. http://codereview.chromium.org/6338014/diff/1/webkit/plugins/ppapi/ppb_url_loader_impl.cc File webkit/plugins/ppapi/ppb_url_loader_impl.cc (right): http://codereview.chromium.org/6338014/diff/1/webkit/plugins/ppapi/ppb_url_loader_impl.cc#newcode470 webkit/plugins/ppapi/ppb_url_loader_impl.cc:470: // TODO(vtl): put ...

9 years, 11 months ago (2011-01-21 21:45:37 UTC) #2

polina

http://codereview.chromium.org/6338014/diff/1/webkit/plugins/ppapi/ppb_url_loader_impl.cc File webkit/plugins/ppapi/ppb_url_loader_impl.cc (right): http://codereview.chromium.org/6338014/diff/1/webkit/plugins/ppapi/ppb_url_loader_impl.cc#newcode470 webkit/plugins/ppapi/ppb_url_loader_impl.cc:470: // TODO(vtl): put this CHECK back when the callback ...

9 years, 11 months ago (2011-01-21 21:48:06 UTC) #3

Committed revision 72229.

Expand Messages | Collapse Messages