Issue 6338013: Handle error case on SSL read which was not properly exiting....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6338013: Handle error case on SSL read which was not properly exiting.... (Closed)

Created:
9 years, 11 months ago by Mike Belshe

Modified:
9 years, 5 months ago

Reviewers:
fenix, kelindsay

CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Handle error case on SSL read which was not properly exiting. BUG=none TEST=<this is the test> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72059

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	net/tools/flip_server/flip_in_mem_edsm_server.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mike Belshe

The DoRead() method is seriously out of control! I've got a looper in this code, ...

9 years, 11 months ago (2011-01-21 00:11:13 UTC) #1

fenix

9 years, 11 months ago (2011-01-21 00:23:39 UTC) #2

That looks fine.
I suppose you're thinking that it keeps not consuming data due to the SSL error,
and thus entering that bit of code again and again?
There is certainly no low-level infinite loop.. so I'd expect that, even if it
got into that mode, it would continue to handle HTTP. If it does, then it would
confirm the problem (SSL stack wedged, spending 100% cpu can happen with zero
effect to the user and is a separate but annoying problem).

In any case, yes, I believe what you have there is correct and what was there
before was not.

We could add a watchdog to watch for this kind of thing (like we've done in
other production code)..

Expand Messages | Collapse Messages