Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 6336005: Remove unused language options code, which has been superseded by DOMUI. (Closed)

Created:
9 years, 11 months ago by falken1
Modified:
9 years, 7 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove unused language options code, which has been superseded by DOMUI. BUG=chromium-os:8307 TEST=Compiled and saw it runs on netbook. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71766

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2784 lines) Patch
D chrome/browser/chromeos/options/language_chewing_config_view.h View 1 chunk +0 lines, -103 lines 0 comments Download
D chrome/browser/chromeos/options/language_chewing_config_view.cc View 1 chunk +0 lines, -242 lines 0 comments Download
D chrome/browser/chromeos/options/language_config_model.h View 1 chunk +0 lines, -148 lines 0 comments Download
D chrome/browser/chromeos/options/language_config_model.cc View 1 chunk +0 lines, -277 lines 0 comments Download
D chrome/browser/chromeos/options/language_config_model_unittest.cc View 1 chunk +0 lines, -98 lines 0 comments Download
D chrome/browser/chromeos/options/language_config_util.h View 1 chunk +0 lines, -101 lines 0 comments Download
D chrome/browser/chromeos/options/language_config_view.h View 1 chunk +0 lines, -150 lines 0 comments Download
D chrome/browser/chromeos/options/language_config_view.cc View 1 chunk +0 lines, -631 lines 0 comments Download
D chrome/browser/chromeos/options/language_hangul_config_view.h View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/chromeos/options/language_hangul_config_view.cc View 1 chunk +0 lines, -185 lines 0 comments Download
D chrome/browser/chromeos/options/language_mozc_config_view.h View 1 chunk +0 lines, -104 lines 0 comments Download
D chrome/browser/chromeos/options/language_mozc_config_view.cc View 1 chunk +0 lines, -273 lines 0 comments Download
D chrome/browser/chromeos/options/language_pinyin_config_view.h View 1 chunk +0 lines, -88 lines 0 comments Download
D chrome/browser/chromeos/options/language_pinyin_config_view.cc View 1 chunk +0 lines, -159 lines 0 comments Download
M chrome/browser/chromeos/options/system_page_view.cc View 3 chunks +0 lines, -138 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
falken1
Patch for bug 8307.
9 years, 11 months ago (2011-01-19 04:13:22 UTC) #1
satorux1
LGTM. Thank you for the clean-up! I'll submit this on behalf of you.
9 years, 11 months ago (2011-01-19 04:17:30 UTC) #2
satorux1
Turned out you needed to update chrome/chrome_tests.gypi. I fixed it locally.
9 years, 11 months ago (2011-01-19 05:28:26 UTC) #3
Charlie Lee
LGTM Looks like we should remove system_page_view also. And remove the kDisableTabbedOptions switch. On 2011/01/19 ...
9 years, 11 months ago (2011-01-28 18:14:12 UTC) #4
falken
9 years, 10 months ago (2011-01-31 01:04:18 UTC) #5
Charlie, since this patch was already committed I created a new issue at
http://codereview.chromium.org/6307019/.  system_page_view has been removed;
I'll look into removing kDisableTabbedOptions.

On 2011/01/28 18:14:12, Charlie Lee wrote:
> LGTM
> 
> Looks like we should remove system_page_view also. And remove the
> kDisableTabbedOptions switch.
> 
> On 2011/01/19 05:28:26, satorux1 wrote:
> > Turned out you needed to update chrome/chrome_tests.gypi. I fixed it
locally.

Powered by Google App Engine
This is Rietveld 408576698