Workaround a nasty ibus issue.

Workaround a nasty ibus issue.

The reason of this bug is:
Because of some reason, ibus will send a fake event to the application for each real key event. These extra fake key events apparently confuse those web apps. This CL tries to suppress those extra key events faked by ibus, while keeping the behavior of other input methods unaffected as much as possible.
It's a hacky workaround. Hope it won't cause any other problem.

BUG=chromium-os:6582
TEST=See bug report.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71883

[James Su, 2011-01-18 20:27:53]

ping

[Daniel Erat, 2011-01-18 20:34:31]

On 2011/01/18 20:27:53, James Su wrote:
> ping

Sorry, I was on vacation.  I've never looked at this code before, so I'm
probably not a very reviewer for this change.

[James Su, 2011-01-18 20:35:52]

On 2011/01/18 20:34:31, Daniel Erat wrote:
> On 2011/01/18 20:27:53, James Su wrote:
> > ping
> 
> Sorry, I was on vacation.  I've never looked at this code before, so I'm
> probably not a very reviewer for this change.
That's alright.

[Yusuke Sato, 2011-01-19 05:55:02]

LGTM

Although the main purpose of the patch is to fix Chromium OS, the change should
also be beneficial for desktop Linux users who are using ibus-1.3.x.  So, even
if could fix ibus (1.4 unstable) for Chromium OS, this workaround is still good
for such Linux users since they have to continue to use ibus-1.3.x (stable) for
a while.

I'd agree that the workaround is very complex though...

-Yusuke

On 2011/01/18 20:35:52, James Su wrote:
> On 2011/01/18 20:34:31, Daniel Erat wrote:
> > On 2011/01/18 20:27:53, James Su wrote:
> > > ping
> > 
> > Sorry, I was on vacation.  I've never looked at this code before, so I'm
> > probably not a very reviewer for this change.
> That's alright.

[Yusuke Sato, 2011-01-19 05:56:10]

Forgot to write:
I've tested the change on Chromium OS tot, and it worked fine.

omnibox: OK
google.com search form: OK
youtube search form: OK

-Yusuke


On 2011/01/19 05:55:02, Yusuke Sato wrote:
> LGTM
> 
> Although the main purpose of the patch is to fix Chromium OS, the change
should
> also be beneficial for desktop Linux users who are using ibus-1.3.x.  So, even
> if could fix ibus (1.4 unstable) for Chromium OS, this workaround is still
good
> for such Linux users since they have to continue to use ibus-1.3.x (stable)
for
> a while.
> 
> I'd agree that the workaround is very complex though...
> 
> -Yusuke
> 
> On 2011/01/18 20:35:52, James Su wrote:
> > On 2011/01/18 20:34:31, Daniel Erat wrote:
> > > On 2011/01/18 20:27:53, James Su wrote:
> > > > ping
> > > 
> > > Sorry, I was on vacation.  I've never looked at this code before, so I'm
> > > probably not a very reviewer for this change.
> > That's alright.