Issue 6335016: Unification: introduce ExternalReference::pending_exception_address().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6335016: Unification: introduce ExternalReference::pending_exception_address(). (Closed)

Created:
9 years, 11 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Unification: introduce ExternalReference::pending_exception_address(). Committed: http://code.google.com/p/v8/source/detail?r=6518

Patch Set 2 : Addressing Mads' concerns #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -26 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	src/assembler.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/assembler.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1	5 chunks	+12 lines, -8 lines	0 comments	Download
M	src/mips/codegen-mips.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/top.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	5 chunks	+5 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/6335016/diff/1/src/assembler.cc File src/assembler.cc (right): http://codereview.chromium.org/6335016/diff/1/src/assembler.cc#newcode717 src/assembler.cc:717: return ExternalReference(Top::k_pending_exception_address); Is there a reason why this ...

9 years, 11 months ago (2011-01-27 13:52:49 UTC) #2

antonm

9 years, 11 months ago (2011-01-27 18:08:13 UTC) #3

Thanks a lot for review, Mads.

Submitting.

http://codereview.chromium.org/6335016/diff/1/src/assembler.cc
File src/assembler.cc (right):

http://codereview.chromium.org/6335016/diff/1/src/assembler.cc#newcode717
src/assembler.cc:717: return
ExternalReference(Top::k_pending_exception_address);
On 2011/01/27 13:52:49, Mads Ager wrote:
> Is there a reason why this is accessing a member and the
> scheduled_exception_address one is calling an accessor?

The only one: older code used this idiom.

Removed.  As a bonus point I removed this constant from TOP_LIST_ADDRESS_LIST.

Expand Messages | Collapse Messages

Issue 6335016: Unification: introduce ExternalReference::pending_exception_address(). (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressing Mads' concerns #

Messages