Issue 6335014: Ensure that normal URLs are not loaded in the NTP process in process-per-tab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6335014: Ensure that normal URLs are not loaded in the NTP process in process-per-tab. (Closed)

Created:
9 years, 11 months ago by Charlie Reis

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr., klobag.chromium, mnaganov (inactive), pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Ensure that normal URLs are not loaded in the NTP process in process-per-tab. BUG=69224 TEST=NewTabUIProcessPerTabTest.NavBeforeNTPCommits Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72806

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -19 lines)			Patch
	M	chrome/browser/dom_ui/new_tab_ui_uitest.cc	View		2 chunks	+37 lines, -0 lines	0 comments	Download
	M	chrome/browser/tab_contents/render_view_host_manager.cc	View		2 chunks	+20 lines, -19 lines	0 comments	Download

Total messages: 2 (0 generated)

Charlie Reis

Just moving the DOM UI check earlier in ShouldSwap, using the SiteInstance's site if there ...

9 years, 11 months ago (2011-01-26 22:13:42 UTC) #1

LGTM