Issue 6335008: Fix Linux breakage of context menu items for the blocked plugin placeholder....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6335008: Fix Linux breakage of context menu items for the blocked plugin placeholder.... (Closed)

Created:
9 years, 11 months ago by Chris Evans

Modified:
9 years, 6 months ago

Reviewers:
Cris Neckar

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix Linux breakage of context menu items for the blocked plugin placeholder. (I'm not sure about other platforms; on Linux, GTK has the weird quirk of firing "context menu closed" before "context menu item selected", so it's best to use a solution that doesn't try and track the visibility state of the context menu). BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71777

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -16 lines)			Patch
	M	chrome/renderer/blocked_plugin.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	chrome/renderer/blocked_plugin.cc	View	1	4 chunks	+10 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Chris Evans

On 2011/01/19 06:33:59, cdn wrote: > LGTM Chatted some more with Cris over chat... we ...

9 years, 11 months ago (2011-01-19 06:37:53 UTC) #3

Looks good with the change

Expand Messages | Collapse Messages