Optimize JSON stringify by allowing QuoteJSONString to prefix with a comma.

Optimize JSON stringify by allowing QuoteJSONString to prefix with a comma.

[Erik Corry, 2011-01-14 14:42:57]

LGTM

http://codereview.chromium.org/6335004/diff/1/src/json.js
File src/json.js (right):

http://codereview.chromium.org/6335004/diff/1/src/json.js#newcode244
src/json.js:244: var not_first = false;
This variable should be called first and the boolean values should be inverted.

http://codereview.chromium.org/6335004/diff/1/src/json.js#newcode247
src/json.js:247: if (not_first) builder.push(%QuoteJSONStringComma(p));
multi-line if statements should use {}

http://codereview.chromium.org/6335004/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6335004/diff/1/src/runtime.cc#newcode4625
src/runtime.cc:4625: static MaybeObject* SlowQuoteJsonString(Vector<const Char>
characters) {
I think it would be nice to know what the performance hit of having this as a
normal argument is, before blowing this code up with a factor of 2.

[sandholm, 2011-01-16 21:08:43]

http://codereview.chromium.org/6335004/diff/1/src/json.js
File src/json.js (right):

http://codereview.chromium.org/6335004/diff/1/src/json.js#newcode244
src/json.js:244: var not_first = false;
On 2011/01/14 14:42:57, Erik Corry wrote:
> This variable should be called first and the boolean values should be
inverted.

Done.

http://codereview.chromium.org/6335004/diff/1/src/json.js#newcode247
src/json.js:247: if (not_first) builder.push(%QuoteJSONStringComma(p));
On 2011/01/14 14:42:57, Erik Corry wrote:
> multi-line if statements should use {}

Done.

http://codereview.chromium.org/6335004/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6335004/diff/1/src/runtime.cc#newcode4625
src/runtime.cc:4625: static MaybeObject* SlowQuoteJsonString(Vector<const Char>
characters) {
On 2011/01/14 14:42:57, Erik Corry wrote:
> I think it would be nice to know what the performance hit of having this as a
> normal argument is, before blowing this code up with a factor of 2.

Having this as a normal argument makes the change regress performance on JSON
stringify rather than improve it.