Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Unified Diff: chrome/browser/resources/options/pref_ui.js

Issue 6335003: Small tabbed options fixes: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/options/preferences.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/pref_ui.js
diff --git a/chrome/browser/resources/options/pref_ui.js b/chrome/browser/resources/options/pref_ui.js
index 58d49a79358bdfaa8a08ae8c0ba664b0bed55741..b6f495c0809f5a4867655ba942efbfc18f0286b6 100644
--- a/chrome/browser/resources/options/pref_ui.js
+++ b/chrome/browser/resources/options/pref_ui.js
@@ -138,20 +138,15 @@ cr.define('options', function() {
}
});
},
-
- /**
- * The name of the preference.
- * @type {string}
- */
- get pref() {
- return this.getAttribute('pref');
- },
- set pref(name) {
- this.setAttribute('pref', name);
- }
};
/**
+ * The preference name.
+ * @type {string}
+ */
+ cr.defineProperty(PrefRadio, 'pref', cr.PropertyKind.ATTR);
+
+ /**
* The user metric string.
* @type {string}
*/
@@ -434,17 +429,6 @@ cr.define('options', function() {
}
});
},
-
- /**
- * The data type for the preference options.
- * @type {string}
- */
- get dataType() {
- return this.getAttribute('dataType');
- },
- set dataType(name) {
- this.setAttribute('dataType', name);
- }
};
/**
@@ -459,6 +443,12 @@ cr.define('options', function() {
*/
cr.defineProperty(PrefSelect, 'metric', cr.PropertyKind.ATTR);
+ /**
+ * The data type for the preference options.
+ * @type {string}
+ */
+ cr.defineProperty(PrefSelect, 'dataType', cr.PropertyKind.ATTR);
+
/////////////////////////////////////////////////////////////////////////////
// PrefTextField class:
« no previous file with comments | « no previous file | chrome/browser/resources/options/preferences.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698