Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 6334137: cros_workon: fix comments/messages to be consistent with new location (Closed)

Created:
9 years, 10 months ago by Mandeep Singh Baines
Modified:
9 years, 7 months ago
Reviewers:
robotboy, anush
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

cros_workon: fix comments/messages to be consistent with new location cros_workon has move to /usr/bin/ BUG=11507 TEST=none Change-Id: I7301f659900713c432104ccceb3e658218e0ecac Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=93da99b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M bash_completion View 1 chunk +1 line, -1 line 0 comments Download
M bin/cros_workon_make View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mandeep Singh Baines
9 years, 10 months ago (2011-02-05 18:37:49 UTC) #1
anush
9 years, 10 months ago (2011-02-05 18:42:21 UTC) #2
LGTM

On Sat, Feb 5, 2011 at 10:37 AM,  <msb@chromium.org> wrote:
> Reviewers: anush, robotboy,
>
> Description:
> cros_workon: fix comments/messages to be consistent with new location
>
> cros_workon has move to /usr/bin/
>
> BUG=11507
> TEST=none
>
> Change-Id: I7301f659900713c432104ccceb3e658218e0ecac
>
> Please review this at http://codereview.chromium.org/6334137/
>
> SVN Base: http://git.chromium.org/git/crosutils.git@master
>
> Affected files:
>  M bash_completion
>  M bin/cros_workon_make
>
>
> Index: bash_completion
> diff --git a/bash_completion b/bash_completion
> index
>
bc9988aaceaa1ee45bac46ea9294f6114f2cd91e..0ff38e456d83b4ab95bb040854c62c51d0180b59
> 100644
> --- a/bash_completion
> +++ b/bash_completion
> @@ -133,7 +133,7 @@ _autotest_complete() {
>  # TODO(petkov): Currently, this assumes that the command is the first
>  # argument. In practice, the command is the first non-flag
>  # argument. I.e., this should be fixed to support something like
> -# "./cros_workon --all list".
> +# "cros_workon --all list".
>  _complete_cros_workon_command() {
>   [ ${COMP_CWORD} -eq 1 ] || return 1
>   local command="${COMP_WORDS[1]}"
> Index: bin/cros_workon_make
> diff --git a/bin/cros_workon_make b/bin/cros_workon_make
> index
>
b4fa489a17b95b9b29973b4005e6f7f62c00f280..a0599f0402e0cb9e234cc1fedf64d37cd7e90472
> 100755
> --- a/bin/cros_workon_make
> +++ b/bin/cros_workon_make
> @@ -71,7 +71,7 @@ workpath=
>  if ! pkgfile=$("${EQUERYCMD}" which "${workon_name}" 2> /dev/null); then
>   if ACCEPT_KEYWORDS="~${BOARD_KEYWORD}" "${EQUERYCMD}" which
> "${workon_name}" \
>       > /dev/null 2>&1; then
> -    die "run './cros_workon --board ${BOARD_STR} start ${1}' first!" 1>&2
> +    die "run 'cros_workon --board ${BOARD_STR} start ${1}' first!" 1>&2
>   fi
>   die "error looking up package $1"
>  fi
>
>
>

Powered by Google App Engine
This is Rietveld 408576698