Issue 6334133: Add utility to pad a given hash for PKCS1.5 signatures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6334133: Add utility to pad a given hash for PKCS1.5 signatures (Closed)

Created:
9 years, 10 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git@master

Visibility:
Public.

Description

Add utility to pad a given hash for PKCS1.5 signatures BUG=n0ne TEST=manual Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=5ab5a37

Patch Set 2 : fix size issue #

Patch Set 3 : fix messages #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -4 lines)			Patch
M	firmware/version.c	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	scripts/sign_data.sh	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	utility/Makefile	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
A	utility/pad_digest_utility.c	View	1 2	1 chunk	+54 lines, -0 lines	0 comments	Download
M	utility/signature_digest_utility.c	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Randall Spangler

LGTM with a couple small output changes. http://codereview.chromium.org/6334133/diff/1/utility/pad_digest_utility.c File utility/pad_digest_utility.c (right): http://codereview.chromium.org/6334133/diff/1/utility/pad_digest_utility.c#newcode27 utility/pad_digest_utility.c:27: fprintf(stderr, "Usage: ...

9 years, 10 months ago (2011-02-05 03:01:39 UTC) #2

gauravsh

9 years, 10 months ago (2011-02-07 19:12:30 UTC) #3

Also made parallel fixes in signature_digest_utility.c on which this is largely
based.

http://codereview.chromium.org/6334133/diff/1/utility/pad_digest_utility.c
File utility/pad_digest_utility.c (right):

http://codereview.chromium.org/6334133/diff/1/utility/pad_digest_utility.c#ne...
utility/pad_digest_utility.c:27: fprintf(stderr, "Usage: %s <algoid>
<digest_file>", argv[0]);
On 2011/02/05 03:01:40, Randall Spangler wrote:
> alg_id?
> 
> algoid sounds like a monster plant... :)

Done.

http://codereview.chromium.org/6334133/diff/1/utility/pad_digest_utility.c#ne...
utility/pad_digest_utility.c:38: fprintf(stderr, "Could read file: %s\n",
argv[2]);
On 2011/02/05 03:01:40, Randall Spangler wrote:
> Could *not* read file?
Done.