Improve ScanJsonNumber.

src/scanner.h

Index: src/scanner.h
===================================================================
--- src/scanner.h	(revision 6635)
+++ src/scanner.h	(working copy)
@@ -148,6 +148,12 @@
   // Returns the next token.
   Token::Value Next();
 
+  // Returns the value of a number token.
+  double number() {

[tfarina, 2011/02/04 15:04:44]

I'll not insist in the const here, but I'd like to know if you tried compiling
with it and it didn't work. Also, I'll not insist in putting everything at the
same line. But it fits and it's very common practice on V8 code.

[Lasse Reichstein, 2011/02/07 08:40:43]

We generally don't use const in the V8 code.
It should work, and probably wouldn't hurt if added, but it's only necessary if
you ever have a const reference to the scanner, and we probably won't have that
either.

As for making it a one-liner ... I wouldn't insist either way either. I prefer
the three-line code, but I can understand the argument for having more
meaningful lines on screen at a atime.

+    return number_;
+  }
+
+
  protected:
   // Skip past JSON whitespace (only space, tab, newline and carrige-return).
   bool SkipJsonWhiteSpace();
@@ -178,6 +184,9 @@
   // are the only valid JSON identifiers (productions JSONBooleanLiteral,
   // JSONNullLiteral).
   Token::Value ScanJsonIdentifier(const char* text, Token::Value token);
+
+  // Holds the value of a scanned number token.
+  double number_;
 };
 
 } }  // namespace v8::internal