Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3064)

Unified Diff: chrome/renderer/resources/extension_process_bindings.js

Issue 6334101: Removal of chrome.experimental.popup set of APIs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extension_process_bindings.js
===================================================================
--- chrome/renderer/resources/extension_process_bindings.js (revision 74596)
+++ chrome/renderer/resources/extension_process_bindings.js (working copy)
@@ -15,8 +15,6 @@
native function GetNextRequestId();
native function OpenChannelToTab();
native function GetRenderViewId();
- native function GetPopupParentWindow();
- native function GetPopupView();
native function SetIconCommon();
native function IsExtensionProcess();
native function IsIncognitoProcess();
@@ -256,12 +254,6 @@
new chrome.Event("toolstrip.onCollapsed." + renderViewId);
}
- function setupPopupEvents(renderViewId) {
- chrome.experimental.popup = chrome.experimental.popup || {};
- chrome.experimental.popup.onClosed =
- new chrome.Event("experimental.popup.onClosed." + renderViewId);
- }
-
function setupHiddenContextMenuEvent(extensionId) {
chromeHidden.contextMenus = {};
chromeHidden.contextMenus.nextId = 1;
@@ -553,71 +545,6 @@
return tabIdProxy;
};
- apiFunctions["experimental.popup.show"].handleRequest =
- function(url, showDetails, callback) {
- // Second argument is a transform from HTMLElement to Rect.
- var internalSchema = [
- this.definition.parameters[0],
- {
- type: "object",
- name: "showDetails",
- properties: {
- domAnchor: {
- type: "object",
- properties: {
- top: { type: "integer", minimum: 0 },
- left: { type: "integer", minimum: 0 },
- width: { type: "integer", minimum: 0 },
- height: { type: "integer", minimum: 0 }
- }
- },
- giveFocus: {
- type: "boolean",
- optional: true
- },
- borderStyle: {
- type: "string",
- optional: true,
- enum: ["bubble", "rectangle"]
- },
- maxSize: {
- type: "object",
- optional: true,
- properties: {
- width: {
- type: "integer", optional: true, minimum: 32
- },
- height: {
- type: "integer", optional: true, minimum: 32
- }
- }
- }
- }
- },
- this.definition.parameters[2]
- ];
- return sendRequest(this.name,
- [url,
- {
- domAnchor: getAbsoluteRect(showDetails.relativeTo),
- giveFocus: showDetails.giveFocus,
- borderStyle: showDetails.borderStyle,
- maxSize: showDetails.maxSize
- },
- callback],
- internalSchema);
- };
-
- apiFunctions["experimental.extension.getPopupView"].handleRequest =
- function() {
- return GetPopupView();
- };
-
- apiFunctions["experimental.popup.getParentWindow"].handleRequest =
- function() {
- return GetPopupParentWindow();
- };
-
var canvas;
function setIconCommon(details, name, parameters, actionType, iconSize,
nativeFunction) {
@@ -794,7 +721,6 @@
setupPageActionEvents(extensionId);
setupToolstripEvents(GetRenderViewId());
- setupPopupEvents(GetRenderViewId());
setupHiddenContextMenuEvent(extensionId);
setupOmniboxEvents();
setupTtsEvents();

Powered by Google App Engine
This is Rietveld 408576698