Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 6334089: Fix array boundary error. (Closed)

Created:
9 years, 10 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix array boundary error. It made value of allowed_access_type[v8::ACCESS_KEYS] be a wild value. On most of platforms it was 0 and tests passed. But on ARM (and on ia32 if you alter test a bit) it could become true and hence allow enumeration of properties. Committed: http://code.google.com/p/v8/source/detail?r=6618

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
antonm
Guys, tiniest review for you.
9 years, 10 months ago (2011-02-03 13:16:44 UTC) #1
Mads Ager (chromium)
LGTM
9 years, 10 months ago (2011-02-03 13:23:28 UTC) #2
Rico
9 years, 10 months ago (2011-02-03 13:32:31 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698