Issue 6334083: Streamline the code for patching optimized code for lazy deopt.

Issue 6334083: Streamline the code for patching optimized code for lazy deopt. (Closed)

Created:
9 years, 10 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge/build/ia32

Visibility:
Public.

Description

Streamline the code for patching optimized code for lazy deopt. Rewrite the lazy deopt patching code on IA32 to use addresses throughout, rather than offsets and a base address. Also, rename a couple of ambiguous Code fields from _start to _offset. Committed: http://code.google.com/p/v8/source/detail?r=6611

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rewrite the incorrect comment mentioning absolute calls. #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -96 lines)			Patch
M	src/arm/deoptimizer-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/deoptimizer.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/disassembler.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/full-codegen.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/deoptimizer-ia32.cc	View	1	2 chunks	+47 lines, -67 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/objects.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	src/runtime.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/safepoint-table.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/deoptimizer-x64.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Rico

LGTM http://codereview.chromium.org/6334083/diff/1/src/ia32/deoptimizer-ia32.cc File src/ia32/deoptimizer-ia32.cc (right): http://codereview.chromium.org/6334083/diff/1/src/ia32/deoptimizer-ia32.cc#newcode93 src/ia32/deoptimizer-ia32.cc:93: RelocInfo rinfo(curr_address + 1, // address is 1 ...

9 years, 10 months ago (2011-02-03 09:44:26 UTC) #2

Kevin Millikin (Chromium)

9 years, 10 months ago (2011-02-04 11:48:54 UTC) #3

http://codereview.chromium.org/6334083/diff/1/src/ia32/deoptimizer-ia32.cc
File src/ia32/deoptimizer-ia32.cc (right):

http://codereview.chromium.org/6334083/diff/1/src/ia32/deoptimizer-ia32.cc#ne...
src/ia32/deoptimizer-ia32.cc:93: RelocInfo rinfo(curr_address + 1,  // address
is 1 after the call opcode
On 2011/02/03 09:44:26, Rico wrote:
> Period at end of comment

I didn't intend it to be a complete sentence, but I guess it accidentally is.

http://codereview.chromium.org/6334083/diff/1/src/ia32/deoptimizer-ia32.cc#ne...
src/ia32/deoptimizer-ia32.cc:94: RelocInfo::RUNTIME_ENTRY,
On 2011/02/03 09:44:26, Rico wrote:
> Maybe we should have a comment stating: "We use RelocInfo::RUNTIME_ENTRY to
mark
> that the actual call address is not moving, even though this is not a runtime
> entry

OK.

Expand Messages | Collapse Messages