Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 6334080: devutil: since devserver.py is here, move the script here as well (Closed)

Created:
9 years, 10 months ago by zbehan
Modified:
9 years, 7 months ago
Reviewers:
sosa, anush
CC:
chromium-os-reviews_chromium.org
Base URL:
http://git.chromium.org/git/dev-util@master
Visibility:
Public.

Description

devutil: since devserver.py is here, move the script start_devserver here as well BUG=n0ne TEST=none Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=9ca7943

Patch Set 1 #

Patch Set 2 : Change path leading to GCLIENT_ROOT into /usr/bin/ #

Patch Set 3 : Move start_devserver to host/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
A host/start_devserver View 1 2 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
zbehan
9 years, 10 months ago (2011-02-03 02:57:39 UTC) #1
zbehan
9 years, 10 months ago (2011-02-03 03:15:54 UTC) #2
anush
It would be nice to prefix scritps being installed with cros_* so that it is ...
9 years, 10 months ago (2011-02-03 15:31:14 UTC) #3
zbehan
Yes, but the shell script has a purpose and is used by some other scripts ...
9 years, 10 months ago (2011-02-03 17:08:59 UTC) #4
anush
Lgtm On Feb 3, 2011 9:09 AM, "Zdenek Behan" <zbehan@chromium.org> wrote: > Yes, but the ...
9 years, 10 months ago (2011-02-03 17:13:38 UTC) #5
zbehan
Should I rename them during the move and move them both into host/ within this ...
9 years, 10 months ago (2011-02-03 17:14:50 UTC) #6
anush
Yes please do. On Feb 3, 2011 9:15 AM, "Zdenek Behan" <zbehan@chromium.org> wrote: > Should ...
9 years, 10 months ago (2011-02-03 17:51:25 UTC) #7
zbehan
9 years, 10 months ago (2011-02-06 03:08:58 UTC) #8
zbehan
OK. I moved start_devserver into host/. I don't want to move devserver.py, for one reason: ...
9 years, 10 months ago (2011-02-06 03:11:46 UTC) #9
anush
9 years, 10 months ago (2011-02-06 03:21:09 UTC) #10
Ok sgtm
On Feb 5, 2011 7:11 PM, "Zdenek Behan" <zbehan@chromium.org> wrote:
> OK. I moved start_devserver into host/.
>
> I don't want to move devserver.py, for one reason: currently some scripts
> use hardcoded path to platform/dev/devserver.py. I think we should first
> finish the split, make sure that all scripts reference devserver through
its
> chroot location, and then move it to host/, as part of refactoring later.
> I also kept the name to start_devserver, because I think it should be
either
> removed or replaced (many scripts go around it and call devserver.py
> directly). Another future refactoring.
>
> So all in all, I'd commit this as it is.
>
> On Sun, Feb 6, 2011 at 4:08 AM, <zbehan@chromium.org> wrote:
>
>> http://codereview.chromium.org/6334080/
>>

Powered by Google App Engine
This is Rietveld 408576698