Issue 6334061: Clean up channel modes

Issue 6334061: Clean up channel modes (Closed)

Created:
9 years, 10 months ago by dmac

Modified:
9 years, 7 months ago

Reviewers:
agl, jeremy

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, jam, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Clean up channel modes Makes channel modes flags instead of a straight enum allowing us to check properties directly. BUG=none TEST=BUILD Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73658

Patch Set 1 #

Patch Set 2 : Missed a file with first upload #

Patch Set 3 : Fix up parens #

Patch Set 4 : Fix up logic bug introduced with last revision #

Total comments: 2

Patch Set 5 : fixed up agl's comments #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -67 lines)			Patch
M	chrome/plugin/plugin_channel_base.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ipc/ipc_channel.h	View	1 2 3 4	1 chunk	+16 lines, -7 lines	0 comments	Download
M	ipc/ipc_channel_posix.h	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	ipc/ipc_channel_posix.cc	View	1 2 3	9 chunks	+25 lines, -34 lines	0 comments	Download
M	ipc/ipc_channel_proxy.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ipc/ipc_channel_win.cc	View		4 chunks	+5 lines, -19 lines	0 comments	Download
M	ipc/ipc_sync_channel_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

agl

I would wait for jeremy to take a look but, in general, LGTM. http://codereview.chromium.org/6334061/diff/3002/ipc/ipc_channel.h File ...

9 years, 10 months ago (2011-02-02 23:31:16 UTC) #2

dmac

Jeremy, any feedback? http://codereview.chromium.org/6334061/diff/3002/ipc/ipc_channel.h File ipc/ipc_channel.h (right): http://codereview.chromium.org/6334061/diff/3002/ipc/ipc_channel.h#newcode76 ipc/ipc_channel.h:76: MODE_SERVER = MODE_SERVER_FLAG & ~MODE_NAMED_FLAG, On ...

9 years, 10 months ago (2011-02-03 17:05:53 UTC) #3

jeremy

9 years, 10 months ago (2011-02-03 18:25:01 UTC) #4

LGTM

On Thu, Feb 3, 2011 at 7:05 PM, <dmaclach@chromium.org> wrote:

> Jeremy, any feedback?
>
>
>
> http://codereview.chromium.org/6334061/diff/3002/ipc/ipc_channel.h
> File ipc/ipc_channel.h (right):
>
>
> http://codereview.chromium.org/6334061/diff/3002/ipc/ipc_channel.h#newcode76
> ipc/ipc_channel.h:76: MODE_SERVER = MODE_SERVER_FLAG & ~MODE_NAMED_FLAG,
> On 2011/02/02 23:31:16, agl wrote:
>
>> I don't understand the reason for the ~MODE_NAMED_FLAG here.
>>
>
> Done.
>
>
> http://codereview.chromium.org/6334061/
>

Expand Messages | Collapse Messages