Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 6334050: Re-enable the test that I disabled last night. (Closed)

Created:
9 years, 10 months ago by Chris Evans
Modified:
9 years, 6 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Re-enable the test that I disabled last night. Handle an AtExitManager either being present or not. The Linux shlibs test has unique considerations of linkage. BUG=30700 TEST=now passes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73590

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -12 lines) Patch
M chrome/test/ui/npapi_uitest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_schedule_timer_test.h View 2 chunks +0 lines, -4 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_thread_async_call_test.h View 1 3 chunks +5 lines, -3 lines 0 comments Download
M webkit/plugins/npapi/test/plugin_thread_async_call_test.cc View 1 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Chris Evans
Captain sherriff?
9 years, 10 months ago (2011-02-03 00:21:47 UTC) #1
cpu_(ooo_6.6-7.5)
9 years, 10 months ago (2011-02-03 00:33:06 UTC) #2
lgtm

Look out for the memory bots after landing in case there are leaks that need to
be handled.

Powered by Google App Engine
This is Rietveld 408576698