Issue 6334046: Disable JingleSessionTest.Connect, JingleSessionTest.TestControlChannel...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6334046: Disable JingleSessionTest.Connect, JingleSessionTest.TestControlChannel... (Closed)

Created:
9 years, 10 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Sergey Ulanov, Alpha Left Google

CC:
chromium-reviews, dmac, awong, garykac, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Disable JingleSessionTest.Connect, JingleSessionTest.TestControlChannel Those tests flakily trigger a libjingle assertion: Error(common.cc:67): e:\b\build\slave\win\build\src\third_party\libjingle\source\talk\session\tunnel\pseudotcpchannel.cc(281): ASSERT FAILED: stream_ != NULL && stream_thread_->IsCurrent() @ cricket::PseudoTcpChannel::Close TBR=hclam BUG=70225 TEST=remoting_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73436

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	remoting/protocol/jingle_session_unittest.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

This is wrong. These tests are broken under TSan but work fine otherwise. We just ...

9 years, 10 months ago (2011-02-02 19:18:44 UTC) #3

Paweł Hajdan Jr.

9 years, 10 months ago (2011-02-02 20:30:36 UTC) #4

This just failed on a Windows trybot, I'm pretty sure the details are either
in the bug, codereview site, or both.

If you need more details please let me know.

On Wed, Feb 2, 2011 at 20:18, <sergeyu@chromium.org> wrote:

> This is wrong. These tests are broken under TSan but work fine otherwise.
> We
> just shouldn't run them under TSan.
>
>
> http://codereview.chromium.org/6334046/
>

Expand Messages | Collapse Messages