Issue 6334045: ARM: Refactor duplicated floating point code in type recording binary operati...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6334045: ARM: Refactor duplicated floating point code in type recording binary operati... (Closed)

Created:
9 years, 10 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Karl Klose

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Refactor duplicated floating point code in type recording binary operation stub. Committed: http://code.google.com/p/v8/source/detail?r=6570

Patch Set 2 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -135 lines)			Patch
	M	src/arm/code-stubs-arm.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	src/arm/code-stubs-arm.cc	View	1	3 chunks	+97 lines, -134 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Karl Klose

LGTM. http://codereview.chromium.org/6334045/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6334045/diff/1/src/arm/code-stubs-arm.cc#newcode2548 src/arm/code-stubs-arm.cc:2548: // Load left and right operands into d6 ...

9 years, 10 months ago (2011-02-02 10:10:14 UTC) #2

Søren Thygesen Gjesse

9 years, 10 months ago (2011-02-02 10:30:30 UTC) #3

http://codereview.chromium.org/6334045/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/6334045/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:2548: // Load left and right operands into d6 and d7
or r0/r1 and r2/r3 depending on
On 2011/02/02 10:10:14, Karl Klose wrote:
> Long line.

Done.

Expand Messages | Collapse Messages

Issue 6334045: ARM: Refactor duplicated floating point code in type recording binary operati... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages